Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding address field for AccountInfo #700

Closed
Ja7ad opened this issue Sep 18, 2023 · 0 comments · Fixed by #703
Closed

Adding address field for AccountInfo #700

Ja7ad opened this issue Sep 18, 2023 · 0 comments · Fixed by #703
Assignees
@kehiy
Labels
good first issue Good for newcomers help wanted Extra attention is needed high priority It has high priority www

Comments

@Ja7ad
Copy link
Contributor

Ja7ad commented Sep 18, 2023

Describe the problem you'd like to have solved

In protocol buffers blockchain.proto we have AccountInfo message for response rpc method GetAccount and GetAccountByNumber but this message don't have address field similar ValidatorInfo

Describe the ideal solution

Idea solution for this problem, we need add address field for response GetAccount and GetAccountByNumber.

Alternatives and current work-around

In ValidatorInfo currently response address.
@Ja7ad Ja7ad added good first issue Good for newcomers help wanted Extra attention is needed high priority It has high priority labels Sep 18, 2023
@kehiy kehiy added the www label Sep 18, 2023
@kehiy kehiy self-assigned this Sep 18, 2023
@kehiy kehiy mentioned this issue Sep 18, 2023
Merged
@b00f b00f closed this as completed in #703 Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kehiy kehiy

Labels
good first issue Good for newcomers help wanted Extra attention is needed high priority It has high priority www
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Adding address field for AccountInfo kehiy/pactus
2 participants
@Ja7ad @kehiy