Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parameter should be obtain from the node #434

Closed
themantre opened this issue Feb 13, 2023 · 3 comments
Closed

parameter should be obtain from the node #434

themantre opened this issue Feb 13, 2023 · 3 comments

Comments

@themantre
Copy link
Contributor

Description

Right now, to calculate the fee we used the default parameters. The parameters should be obtained from the node.

How To Reproduce

Send a transaction in TestNet with the Minimum Fee. For example set the amount to 0.0001.

What Happened

The transaction fails, because the TestNet Parameters are not same as default parameters. Look at calcfee function.

Expected Behavior

The parameters should be obtained from the node.
@kehiy kehiy assigned kehiy and unassigned kehiy Jul 17, 2023
@b00f
Copy link
Collaborator

b00f commented Jul 26, 2023

Fixing #590 will eliminate the need to know consensus parameters for fee calculation.

@kehiy
Copy link
Contributor

kehiy commented Dec 11, 2023 •
edited
Loading

@b00f

is fixed, should we close it?

@b00f
Copy link
Collaborator

b00f commented Dec 11, 2023

Yes, we can dude.

@b00f b00f closed this as completed Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@b00f @themantre @kehiy