feat(can-i-deploy): skip --retry-while-unknown if --dry-run true

fixes #149
pact-foundation · Aug 7, 2024 · cbbcc0a · cbbcc0a
1 parent 7d71aeb
commit cbbcc0a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/pact_broker/client/can_i_deploy.rb b/lib/pact_broker/client/can_i_deploy.rb
@@ -109,7 +109,7 @@ def fetch_matrix
 
       def fetch_matrix_with_retries
         matrix = fetch_matrix
-        if retry_while_unknown?
+        if retry_while_unknown? && !dry_run_or_false
           check_if_retry_while_unknown_supported(matrix)
           if matrix.any_unknown?
             results = matrix.unknown_count == 1 ? "result" : "results"

diff --git a/spec/lib/pact_broker/client/can_i_deploy_spec.rb b/spec/lib/pact_broker/client/can_i_deploy_spec.rb
@@ -163,9 +163,9 @@ module Client
               expect(subject.success).to be true
             end
 
-            it "returns a failure message" do
+            it "returns a success message" do
               expect(subject.message).to include "[dry-run]"
-              expect(subject.message).to match /does not provide a count/
+              expect(subject.message).to match /Dry run enabled - ignoring any failures/
             end
           end
         end