Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Handle x509 certs in HTTP Client #298

Conversation

gmolki
Copy link
Contributor

@gmolki gmolki commented Sep 13, 2023

Goal of this PR is to enable the usage of x509 certificates in http requests.

Related PR in pact-support: pact-foundation/pact-support#99

@bethesque bethesque self-requested a review September 13, 2023 23:35
@bethesque
Copy link
Member

I will merge when this uses the same approach we agreed on for the pact broker client.

@bethesque
Copy link
Member

Can you please add docs for this as well. I think the best place to document it is here https://docs.pact.io/implementation_guides/ruby/configuration

Would you mind adding the docs for the SSL certs while you're at it?

@YOU54F
Copy link
Member

YOU54F commented Oct 13, 2023

Thanks for the updates @gmolki 👍🏾

@bethesque bethesque merged commit 3ed5680 into pact-foundation:master Oct 30, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants