Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request/Response logging is enabled under debug mode but output as trace mode so is never output to the logs #834

Closed
4 tasks done
YOU54F opened this issue Mar 9, 2022 · 1 comment · Fixed by #835
Closed
4 tasks done
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@YOU54F
Copy link
Member

YOU54F commented Mar 9, 2022

Thank you for reporting a bug! We appreciate it very much. Issues are a big input into the priorities for Pact-JS development

All italic text in this template is safe to remove before submitting

Thanks again!

Software versions

Please provide at least OS and version of pact-js

  • OS: _e.g. Mac OSX 12.2.1
  • Consumer Pact library: _e.g. Pact JS 9.17.2
  • Provider Pact library: _e.g. Pact JS 9.17.2
  • Node Version: node --version v16.13.1

Issue Checklist

Please confirm the following:

  • I have upgraded to the latest
  • I have the read the FAQs in the Readme
  • I have triple checked, that there are no unhandled promises in my code and have read the section on intermittent test failures
  • I have set my log level to debug and attached a log file showing the complete request/response cycle
  • [] For bonus points and virtual high fives, I have created a reproduceable git repository (see below) to illustrate the problem

Expected behaviour

setting debug in the logs, outputs request/response logging when using Verifier in pact-js

Actual behaviour

request/response logging is enabled, but under trace mode.

Steps to reproduce

Run pact-verify with logs output to debug

Relevant log files

Initial PR raised here #462
Required entry log level dropped to debug here efa1e10#diff-bcf94b082b5b493850358e0d5c89b94a20bf5fac5e6e5261c339688891f16047R131

associated code here

https://github.com/pact-foundation/pact-js/blob/master/src/dsl/verifier.ts#L214

and here

logger.trace(

want updating to logger.debug :)

@YOU54F YOU54F added the bug Indicates an unexpected problem or unintended behavior label Mar 9, 2022
@YOU54F
Copy link
Member Author

YOU54F commented Mar 9, 2022

worth noting there are a couple of other instances of logger.trace that might be worth catching too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant