Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consumerVersionTags got overwritten with empty array #714

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

Lyr-7D1h
Copy link
Contributor

Fixes #713

The consumerVersionTags, providerVersionTags and consumverVersionSelectors were overwritten with an empty array.

I hope you don't mind I used a formatter. Only changed code in fn get_string_array and fn verify_provider

@mefellows
Copy link
Member

mefellows commented Jul 21, 2021

Thanks for this.

I hope you don't mind I used a formatter

Unfortunately, despite the formatting in its current state not being ideal, this makes it really hard to bring in. Would you mind re-submitting without the formatting changes?

@Lyr-7D1h
Copy link
Contributor Author

@mefellows Updated the commit to not include the formatting.

@mefellows
Copy link
Member

Amazing - thanks @Lyr-7D1h! Will merge and get a fresh release out this evening.

@mefellows mefellows merged commit 838d1cb into pact-foundation:feat/v3.0.0 Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants