fix: set process.stdout._handle.setBlocking(true) on ffi init #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes pact-foundation/pact-js#1216 Large number of pact verifications fail when run in parallel
|
The only additional comment I would make is, do we need to consider undoing that operation when pact shuts down? Probably unnecessary. |
|
I've assumed it's killed with the node process for the sake of simplicity of getting a fix out. Certainly happy to go for a belt and braces approach (being set at a test lifecycle start and end, rather than when the ffi init is called ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes pact-foundation/pact-js#1216
Large number of pact verifications fail when run in parallel