Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use offsetHeight instead of getBoundingClientRect to calculate list height #120

Closed
pacocoursey opened this issue Apr 17, 2023 · 0 comments · Fixed by #121
Closed

Use offsetHeight instead of getBoundingClientRect to calculate list height #120

pacocoursey opened this issue Apr 17, 2023 · 0 comments · Fixed by #121
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pacocoursey
Copy link
Owner

offsetHeight ignores transforms, so it may calculate the wrong height when a scale or transform is applied to the List or any parent elements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use offsetHeight to calculate list height joaom00/cmdk
1 participant
@pacocoursey