Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to tighten encoding handling for some types. #180

Open
pombredanne opened this issue Feb 12, 2025 · 1 comment
Open

Need to tighten encoding handling for some types. #180

pombredanne opened this issue Feb 12, 2025 · 1 comment

Comments

@pombredanne
Copy link
Member

This is problematic:

>>> P.from_string("pkg:pypi/foo:bar@1.2.3")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/tmp/purl/venv/lib/python3.10/site-packages/packageurl/__init__.py", line 508, in from_string
    raise ValueError(msg)
ValueError: Invalid purl 'pkg:pypi/foo:bar@1.2.3' cannot contain a "user:pass@host:port" URL Authority component: ''.
>>> P.from_string("pkg:maven/com.apache:foo/foobar@1.2.3")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/tmp/purl/venv/lib/python3.10/site-packages/packageurl/__init__.py", line 508, in from_string
    raise ValueError(msg)
ValueError: Invalid purl 'pkg:maven/com.apache:foo/foobar@1.2.3' cannot contain a "user:pass@host:port" URL Authority component: ''.
>>> P.from_string("pkg:maven/com.apache$3Afoo/foobar@1.2.3")
PackageURL(type='maven', namespace='com.apache$3Afoo', name='foobar', version='1.2.3', qualifiers={}, subpath=None)
>>> P.from_string("pkg:maven/com.apache%3Afoo/foobar@1.2.3")
PackageURL(type='maven', namespace='com.apache:foo', name='foobar', version='1.2.3', qualifiers={}, subpath=None)
>>> str(P.from_string("pkg:maven/com.apache%3Afoo/foobar@1.2.3"))
'pkg:maven/c
om.apache:foo/foobar@1.2.3'

See also package-url/purl-spec#39

@pombredanne
Copy link
Member Author

We cannot round trip:

>>> from packageurl import PackageURL as P
>>> P.from_string(str(P.from_string("pkg:maven/com.apache%3Afoo/foobar@1.2.3")))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/tmp/purl/venv/lib/python3.10/site-packages/packageurl/__init__.py", line 508, in from_string
    raise ValueError(msg)
ValueError: Invalid purl 'pkg:maven/com.apache:foo/foobar@1.2.3' cannot contain a "user:pass@host:port" URL Authority component: ''.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant