Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to dump disassembly of PGO optimized builds? #196

Closed
playXE opened this issue Aug 12, 2023 · 3 comments · Fixed by #268
Closed

How to dump disassembly of PGO optimized builds? #196

playXE opened this issue Aug 12, 2023 · 3 comments · Fixed by #268

Comments

@playXE
Copy link

playXE commented Aug 12, 2023

The question is in issue name. I am using cargo-pgo for doing PGO builds, is there any way to use cargo asm on it?

@pacak
Copy link
Owner

pacak commented Aug 12, 2023

Not at the moment. I might add it at some point.

@playXE
Copy link
Author

playXE commented Aug 12, 2023

What are the required steps to add it? I might make a PR as it is important feature for me.
@pacak

@pacak
Copy link
Owner

pacak commented Aug 12, 2023

Currently cargo-show-asm works by asking rustc to produce an .s file (and more importantly explain where this file was produced). If cargo-pgo can do that adding should be relatively easy. If it can't - maybe make a feature request with them.

Second approach would be running objdump on the generated binary and doing the same stuff it does already for .s files. I wanted to implement this at some point, even made a ticket #174 :) I think current asm parser might be extended just enough to support this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants