Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit Protobuf include directory policy #4477

Closed
fruffy opened this issue Feb 27, 2024 · 0 comments · Fixed by #4543
Closed

Revisit Protobuf include directory policy #4477

fruffy opened this issue Feb 27, 2024 · 0 comments · Fixed by #4543
Assignees
@fruffy
Labels
control-plane Topics related to the control-plane or P4Runtime. enhancement This topic discusses an improvement to existing compiler code.

Comments

@fruffy
Copy link
Collaborator

fruffy commented Feb 27, 2024

Now that we have increased the minimum Protobuf version we may actually be able to request a Protobuf version that includes the fixes to the CMake config file. This way we can just link to Protobuf normally instead of manually patching libraries and includes.
@fruffy fruffy added enhancement This topic discusses an improvement to existing compiler code. control-plane Topics related to the control-plane or P4Runtime. labels Feb 27, 2024
@fruffy fruffy self-assigned this Mar 5, 2024
@fruffy fruffy mentioned this issue Mar 7, 2024
Merged
@fruffy fruffy mentioned this issue Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fruffy fruffy

Labels
control-plane Topics related to the control-plane or P4Runtime. enhancement This topic discusses an improvement to existing compiler code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aggressively clean up the Protobuf CMake dependency. p4lang/p4c
1 participant
@fruffy