Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI Accessory support for Door and Window #945

Merged
merged 5 commits into from
Nov 10, 2020
Merged

Add UI Accessory support for Door and Window #945

merged 5 commits into from
Nov 10, 2020

Conversation

Feilner
Copy link
Contributor

@Feilner Feilner commented Nov 9, 2020

Add pictures for Door and Window. Functionality is identically/copied from WindowCovering.

Window:
image

Door:
image

Note: The Pictures are done by my self and free of any rights.

Result of npm run test:e2e:

Test Suites: 18 passed, 18 total
Tests: 140 passed, 140 total
Snapshots: 0 total
Time: 36.575 s

@Feilner Feilner mentioned this pull request Nov 9, 2020
65 tasks
@oznu
Copy link
Member

oznu commented Nov 10, 2020

Thanks @Feilner, looks great. Can you confirm the icons look ok with a dark mode theme enabled?

@oznu oznu merged commit 3e439f7 into homebridge:master Nov 10, 2020
@Feilner
Copy link
Contributor Author

Feilner commented Nov 10, 2020

Thanks for merging. I can confirm that the are also looking good at dark mode.
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants