Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Developer] Settings panel dropdown saves string "null" instead of removing parameter #665

Closed
normen opened this issue May 6, 2020 · 2 comments
Labels

Comments

@normen
Copy link

normen commented May 6, 2020

Describe The Bug:

When using a dropdown in the settings panel for a non-required string the config.json will store "parameter": "null" when selecting "None" in the dropdown.

To Reproduce:

Use e.g. homebridge-bravia and select "None" as TV input, see here: https://github.com/normen/homebridge-bravia/blob/master/config.schema.json

Expected behavior:

The settigs panel should remove the non-required variables where "None" is selected in the dropdown.

Logs:

  • no errors -
Show the Homebridge / Homebridge Config UI X logs here.

Homebridge Config:

Show your homebridge config.json here

Screenshots:

Environment:

  • Node.js Version:
    v10.20.1
  • NPM Version:
    v6.14.4
  • Homebridge Version:
    v1.0.4
  • Homebridge Config UI X Version:
    v4.17.1
  • Operating System: Raspbian / Ubuntu / Debian / Windows / macOS / Docker
    Raspbian 9 "Stretch
  • Process Supervisor: Docker / Systemd / init.d / pm2 / launchctl / hb-service / other / none
    systemd
@normen normen added the bug label May 6, 2020
@normen normen changed the title [Developer] Settings panel dropdown saves string "null" instead of null [Developer] Settings panel dropdown saves string "null" instead of removing parameter May 6, 2020
@oznu
Copy link
Member

oznu commented May 6, 2020

Hi @normen,

Can you test 4.17.3-test.6 (or latest @test) and let me know if the issue is resolved there?

https://github.com/oznu/homebridge-config-ui-x/wiki/How-To-Test-Upcoming-Changes

Thanks.

@oznu oznu closed this as completed in 09a3c6e May 6, 2020
@normen
Copy link
Author

normen commented May 6, 2020

Yes it is, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants