keep orphans instead of remove #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work @nicoduj - thanks for this 😄 |
|
I made a small change to only apply the |
|
Indeed , better this way, even if I hope everyone will upgrade quickly (since from a plugin side maintaining compatibility could be challenge if we want to adopt new prototypes ) . Is there no way to block the upgrade of plugins like config ui on 0.4 branch of homebridge ? By using package.json versioning or some other trick ? It would involve maintaining a legacy branch , but would make code much cleaner if we have to handle such « ifs » no ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a proposition if it can help, first time so I hope I saw everything !