Adding "Hide the used Port"-Option in HomebridgeStatusWidget #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Staubgeborener
changed the title
|
Thanks; I'll check this out soon. We can probably get the translations for "running on port" from an older commit: https://github.com/oznu/homebridge-config-ui-x/tree/140858974f48034ae64cb99aa3cc570fbef26d54/ui/src/i18n |
Caribsky
approved these changes
Mar 1, 2020
|
Hi, @Staubgeborener |
Caribsky
approved these changes
Mar 1, 2020
|
Thanks @Staubgeborener and @Caribsky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a response to #558.
The used port is no longer displayed (on purpose) within the current version. The wrong spelling "running" was already fix'd. But I believe that it should be left open to the community whether they want to display the port or not. I mean, at least one person (also me) misses it. So i added an option "Hide the used Port" for the HomebridgeStatusWidget. You don't want the port? Check the box. You want the port? Uncheck it.
I have also prepared all language files. But one or two lines have to be translated again. Not a big deal.
P.S.: In this PR is also a corrected grammatical mistake in
de.json.