Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update de.json #567

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Update de.json #567

merged 1 commit into from
Feb 27, 2020

Conversation

Staubgeborener
Copy link
Contributor

@Staubgeborener Staubgeborener commented Feb 27, 2020

I think thats a good compromise between @buenyamin-olgun PR #565 and my PR #563

Reasons:

  1. We use compound words in de.json, like L47 "Homebridge-Gerätesteuerung" instead of "Homebridge Gerätesteuerung" (more examples: L71, L187, L210, et cetera).

  2. In my opinion the word "Paarungen" (L60) is too much like a 1:1 translation and does not include the actual meaning in german. I would either use "Verbindung" (german) or stay with the original version "Pairing" (see L224).

  3. It has already been decided that "cached accessories" means "gecachte Geräte" L185 in german and not "gecachten Accessories".

  4. Spelling mistake: "aktuelel" instead of "aktuelle" (L62)

Maybe someone can still look over the commas.

@oznu
Copy link
Member

oznu commented Feb 27, 2020

Thanks @Staubgeborener and @buenyamin-olgun!

@oznu oznu merged commit 28bbc84 into homebridge:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants