Added 'Speaker' and 'Battery Service' component #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @LaborEtArs, this is an amazing effort. I'll test this out soon. |
Caribsky
approved these changes
Jan 23, 2020
| @@ -18,6 +18,10 @@ | |||
| "accessories.control.label_on": "Вкл", | |||
| "accessories.control.label_open": "Открыто", | |||
| "accessories.control.label_opening": "Открывается", | |||
| "accessories.control.label_batteryservice_notcharging": "Не заряжается", | |||
| "accessories.control.label_batteryservice_charging": "Зарядка", | |||
| "accessories.control.label_batteryservice_notchargeable": "Не оплачивается", | |||
There was a problem hiding this comment.
The correct translation in case when charging is not supported:
Suggested change
| "accessories.control.label_batteryservice_notchargeable": "Не оплачивается", | |
| "accessories.control.label_batteryservice_notchargeable": "Без зарядки", |
| "accessories.control.label_batteryservice_notcharging": "Не заряжается", | ||
| "accessories.control.label_batteryservice_charging": "Зарядка", | ||
| "accessories.control.label_batteryservice_notchargeable": "Не оплачивается", | ||
| "accessories.control.label_speaker_volume": "объем", |
There was a problem hiding this comment.
Suggested change
| "accessories.control.label_speaker_volume": "объем", | |
| "accessories.control.label_speaker_volume": "Громкость", |
|
Ah I can't add @Caribsky changes after merging. Let me try something, I might break this PR.. |
|
I applied them manually. |
|
Thanks @LaborEtArs and @Caribsky for your contribution. |
|
This is currently in You can install the test version using: |
|
I have tested the new battery service component only. Well done! Thanks guys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was a long way to go... but now:
Added 'Speaker' and 'Battery Service' component!
Both components are mostly 'stolen' from 'Lightbulb' and 'Thermostat'.
The translations are from 'google', so there is definitely potential for optimizations ;-)