Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle deep plugin homepage when searching for latest release #1103

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

dgreif
Copy link
Contributor

@dgreif dgreif commented Feb 26, 2021

The homebridge-ring plugin hasn't been showing the initial release notes before updating for a while now. Finally took a second to track it down and it looks like it's because my homepage url is a little non-standard: https://github.com/dgreif/ring/tree/master/homebridge#homebridge-ring. Took a more generic approach to your url parsing and look specifically for the user/repo parts of the url using regex. Still works for homepages with #readme (or any other #) at the end

@dgreif
Copy link
Contributor Author

dgreif commented Feb 26, 2021

Just thinking about it more, should it use repo.url from the package instead of homepage? Seems like that would be more reliable, especially if someone had a custom homepage hosted elsewhere.

@oznu
Copy link
Member

oznu commented Mar 2, 2021

Thanks!

@oznu oznu merged commit 18d3031 into homebridge:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants