Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Humidifier / Dehumidifier #1100

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Add Humidifier / Dehumidifier #1100

merged 1 commit into from
Mar 2, 2021

Conversation

Feilner
Copy link
Contributor

@Feilner Feilner commented Feb 26, 2021

This PR adds the Accessory HumidifierDehumidifier.
The functionality is similar to the HeaterCooler wich where used as base.

For UI consistency it also changes the way how the Humidity Sensor is displayed. Instead of displaying the value below the name it shows it similar to the temperature inside a water drop that is created by css transformations.

Old UI

image

New UI

The color code for the icon is:
gray: plain sensor, off or current status inactive
green: current status idle
blue: current status humidifying
orange: current status dehumidifying
image
image
image
image

DarkMode

image
image

Language files:

The following new labels where added to the language files.

"accessories.control.label_dehumidifying": "Dehumidifying",
"accessories.control.label_humidifying": "Humidifying",
"accessories.control.label_target_humidity": "Target Humidity",

Translation in German is available all others where added in English

Test Result:

npm run test:e2e
...
Test Suites: 18 passed, 18 total
Tests:       184 passed, 184 total
Snapshots:   0 total
Time:        35.803 s

Questions?

Just ask me!

Note: I just saw that my editor removed trailing spaces if that's an issue I can change this back.

@Feilner
Copy link
Contributor Author

Feilner commented Feb 26, 2021

@oznu It seems that the tests have had an temporary error. Could you start the pipeline again?

I enabled the pipeline on my fork to test run the tests but unfortunately I created the test PR to your repro #1101. Sorry for that.
But at least it did what it should show that it was a temporary error see:
https://github.com/oznu/homebridge-config-ui-x/actions/runs/602013741

@oznu
Copy link
Member

oznu commented Mar 2, 2021

Looks great! Thanks!

@oznu oznu merged commit ed23538 into homebridge:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants