Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Editor: Show diff to compare current and to-be-restored config #910

Closed
joberembt opened this issue Oct 22, 2020 · 3 comments
Closed

Comments

@joberembt
Copy link

Is your feature request related to a problem? Please describe:

When trying to restore a config from the saved/cached configs, it's hard to differentiate between them to know which one you want.

Describe the solution you'd like:
I suggest allowing a small text field when saving that you can summarize changes to be able to refer back to them easier, like 'removed manual device entry'. Then, when trying to pick one, you could see the one that has the change you were looking for vs a Date/Time to try to pick based on a wild guess. Conversely, maybe have a basic diff tool style view that could be toggled to show/hide the diff between the currently loaded config and the one to potentially restore.

@oznu
Copy link
Member

oznu commented Oct 26, 2020

There isn't really any metadata storage for this sort of thing - the timestamps are derived from the file name.

Conversely, maybe have a basic diff tool style view that could be toggled to show/hide the diff between the currently loaded config and the one to potentially restore.

What about this?

image

You can test it in @test:

https://github.com/oznu/homebridge-config-ui-x/wiki/How-To-Test-Upcoming-Changes

@joberembt
Copy link
Author

@oznu Yes, something like that is what I was thinking. One small change I would like to see to it though, is to label which pane is which above each pane.

Thanks for adding this!

--JOsh

@oznu
Copy link
Member

oznu commented Oct 27, 2020

Landing in v4.31.0.

@oznu oznu closed this as completed Oct 27, 2020
@oznu oznu changed the title Allow for a short description of changes made when saving config Config Editor: Show diff to compare current and to-be-restored config Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants