Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Developer] Settings Panel description appears twice #535

Closed
normen opened this issue Feb 11, 2020 · 7 comments
Closed

[Developer] Settings Panel description appears twice #535

normen opened this issue Feb 11, 2020 · 7 comments
Labels

Comments

@normen
Copy link

normen commented Feb 11, 2020

Describe The Bug:
When adding a "description" tag to an array the description appears in two places, see this image:
https://i.imgur.com/eRCsGGk.png
(note the text :"leave empty to...")

To Reproduce:
Add an array to config.schema.json and give it a description, see this config.schema.json producing the output above.
https://github.com/normen/homebridge-bravia/blob/master/config.schema.json

Expected behavior:
The description should only appear in the

Logs:
See image above

Homebridge Config:

omitted, see config.schema.json above

Screenshots:
https://i.imgur.com/eRCsGGk.png

Environment:

  • Node.js Version: 10.15
  • NPM Version: 6,9
  • Homebridge Version: 0.50
  • Homebridge Config UI X Version: 0.4.10
  • Operating System: Raspbian
  • Process Supervisor: Systemd
@normen normen added the bug label Feb 11, 2020
@oznu
Copy link
Member

oznu commented Feb 11, 2020

Hi @normen - after spending to long trying to figure this out - it looks like a bug in the upstream library (https://github.com/hamzahamidi/ajsf).

I'll try work on it more later.

@oznu
Copy link
Member

oznu commented Feb 11, 2020

The same duplicate description effect can be seen in the demonstration playground.

@normen
Copy link
Author

normen commented Feb 11, 2020

Thanks for checking, no biggie for now, just thought it should be documented. Cheers!

@donavanbecker
Copy link
Contributor

I experienced this two when I was going through different plugins to add the config.schema.json. I believe I was able to work around this by adding the layout schema, and adding the description there.

@oznu
Copy link
Member

oznu commented Feb 11, 2020

@donavanbecker - that's what I thought would be the solution as well. It turns out that doesn't work so well when using nested arrays inside nested arrays.

@donavanbecker
Copy link
Contributor

@oznu Good to know.

@oznu oznu closed this as completed in 1b5c678 Feb 12, 2020
@normen
Copy link
Author

normen commented Feb 12, 2020

Awesomesauce, my settings panel looks very nice now, thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants