add avahi Advertiser to UI #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oznu
reviewed
Jan 6, 2022
oznu
reviewed
Jan 6, 2022
| @@ -45,6 +45,7 @@ <h5 class="primary-text mt-3" translate="settings.network.title_network"></h5> | |||
| <select class="custom-select" [formControl]="legacyMdnsFormControl" | |||
| [attr.aria-label]=" 'settings.mdns_advertiser' | translate"> | |||
| <option value="bonjour-hap">Bonjour HAP</option> | |||
| <option value="avahi">Avahi</option> | |||
There was a problem hiding this comment.
We could only display this option if the user is running Linux.
There was a problem hiding this comment.
Maybe having a way for the UI to check if Avahi is available would be useful, as when running Docker the "avahi" service is only started on the Ubuntu variant of the image by default.
Leave that with me though.
There was a problem hiding this comment.
Can we interface with homebridge to report which advertiser was picked in "choose default" mode? see homebridge/HAP-NodeJS#922
|
@oznu, any other changes needed to get this merged? and into a beta? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add avahi Advertiser to Homebridge UI for Homebridge v1.4.0-beta