Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a test for aarch64 big-endian target #10

Open
ozgrakkurt opened this issue Feb 29, 2024 · 1 comment · Fixed by #11
Open

Have a test for aarch64 big-endian target #10

ozgrakkurt opened this issue Feb 29, 2024 · 1 comment · Fixed by #11
Labels
bug Something isn't working enhancement New feature or request

Comments

@ozgrakkurt
Copy link
Owner

Should check if big endian is enabled on aarch64 and use fallback impl if it is. This should be rare but is a critical bug
@ozgrakkurt ozgrakkurt added the bug Something isn't working label Feb 29, 2024
@ozgrakkurt ozgrakkurt mentioned this issue Feb 29, 2024
Merged
@ozgrakkurt
Copy link
Owner Author

https://releases.llvm.org/9.0.0/docs/BigEndianNEON.html

Maybe LLVM already handles this when compiling for big endian. Need to have a test for this then can remove #cfg(target_endian = "little") stuff from code

@ozgrakkurt ozgrakkurt reopened this Mar 1, 2024
@ozgrakkurt ozgrakkurt added the enhancement New feature or request label Mar 1, 2024
@ozgrakkurt ozgrakkurt changed the title possibly bugged on aarch64 target with big endian enabled Have a test for aarch64 big-endian target Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: check if target is little-endian on arm64 and wasm32 ozgrakkurt/sbbf-rs
1 participant
@ozgrakkurt