Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aura Handling Refactoring #54

Open
oyachai opened this issue Jan 1, 2015 · 2 comments
Open

Aura Handling Refactoring #54

oyachai opened this issue Jan 1, 2015 · 2 comments

Comments

@oyachai
Copy link
Owner

oyachai commented Jan 1, 2015

Currently, Aura handling is a mess and there are bugs associated with mind controlling (Mind Control, Cabal Shadow Priest, etc) a minion that applies Auras (Stormwind Champion, etc).

My current thinking is to move the Aura handling to BoardModel and adding a MinionWithAura interface that all minions with Aura effects implement. BoardModel will check for this interface in placeMinion(...) and removeMinion(...) and apply/remove any auras necessary through the interface.
@oyachai
Copy link
Owner Author

oyachai commented Jan 1, 2015

working on it

@MrHen
Copy link
Contributor

MrHen commented Mar 1, 2015

Did this get completed? I saw changes related to auras after I merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MrHen @oyachai