Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw builds are going to start failing with Ruby 3.4 #46

Open
gjtorikian opened this issue Dec 2, 2024 · 1 comment
Open

mingw builds are going to start failing with Ruby 3.4 #46

gjtorikian opened this issue Dec 2, 2024 · 1 comment

Comments

@gjtorikian
Copy link
Collaborator

I've been looking into why commonmarker's mingw builds have been failing:

 thread 'main' panicked at C:\Users\runneradmin/.cargo\registry\src\index.crates.io-6f17d22bba15001f\rb-sys-0.9.103\build/main.rs:49:6:
  generate bindings: ClangDiagnostic("D:/rubyinstaller-head-x64/include/ruby-3.4.0+1/ruby/internal/stdckdint.h:48:11: error: 'stdckdint.h' file not found with <angled> include; use \"quotes\" instead\n")

stckdint.h is a C23 header: ruby/ruby#10632

Clang 18 supported it: https://releases.llvm.org/18.1.6/tools/clang/docs/ReleaseNotes.html#c23-feature-support

But the mingw builds explicitly lock to v15:

# for now we have to use clang-15 for mingw builds, since our bindgen is too old to work with clang-16
mingw: clang-15

I couldn't go back far enough to understand why the mingw builds couldn't upgrade. But, this will almost certainly break for others later this month when Ruby 3.4 is released.

cc @ianks

@ianks
Copy link
Contributor

ianks commented Dec 9, 2024

we can try to bump to clang 18, but IIRC there were other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants