Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag for new asm_sym feature #41

Closed
bnaecker opened this issue Nov 8, 2021 · 1 comment
Closed

Add flag for new asm_sym feature #41

bnaecker opened this issue Nov 8, 2021 · 1 comment
Assignees
@bnaecker
Labels
🐛 bug Something that isn't working.

Comments

@bnaecker
Copy link
Collaborator

bnaecker commented Nov 8, 2021

The tests for PR #40 originally failed. This is unrelated to the code in the PR itself, but due to a recently-merged set of feature flags related to inline assembly.

USDT uses inline assembly in its implementation, which has been in the stabilization process for a while. That's behind a feature flag asm, but during stabilization, that feature has been broken out into several more fine-grained ones. This specific message is due to the use of the symbol operands on macOS.
@bnaecker bnaecker added the 🐛 bug Something that isn't working. label Nov 8, 2021
@bnaecker bnaecker self-assigned this Nov 8, 2021
This was referenced Nov 8, 2021
Merged
Merged
@bnaecker
Copy link
Collaborator Author

bnaecker commented Nov 9, 2021

Closed by #45.

@bnaecker bnaecker closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bnaecker bnaecker

Labels
🐛 bug Something that isn't working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bnaecker