Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(linter) error in fixer for perfer to have length #5195

Closed
camc314 opened this issue Aug 25, 2024 · 0 comments · Fixed by #5197
Closed

bug(linter) error in fixer for perfer to have length #5195

camc314 opened this issue Aug 25, 2024 · 0 comments · Fixed by #5197
Labels
C-bug Category - Bug

Comments

@camc314
Copy link
Contributor

camc314 commented Aug 25, 2024

See https://github.com/bbc/simorgh/blob/latest/src/app/legacy/containers/StoryPromo/index.test.jsx

        expect(assetTypeContainer.getElementsByTagName('time').length).toEqual(
          0,
        );

is being fixed to

expect(assetTypeContainer.getElementsByTagName('time')).toHaveLength 0,
    );

which is incorrect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(linter): error in fixer for prefer-to-have-length shulaoda/oxc
1 participant
@camc314