From 2101af684ae28a6886bee5781a0229539a739368 Mon Sep 17 00:00:00 2001
From: Jannik Stehle <jannik.stehle@gmail.com>
Date: Tue, 22 Mar 2022 08:58:51 +0100
Subject: [PATCH 1/4] Implement link sharing for and in spaces

---
 .../SideBar/Details/SpaceDetails.vue          | 40 ++++++++---
 .../components/SideBar/Links/FileLinks.vue    | 32 +++++++--
 .../SideBar/Links/PublicLinks/LinkActions.vue |  9 ++-
 .../SideBar/Links/PublicLinks/LinkEdit.vue    | 14 +++-
 .../SideBar/Links/PublicLinks/LinkInfo.vue    | 13 ++--
 .../components/SideBar/Shares/SpaceShares.vue | 19 +++--
 packages/web-app-files/src/fileSideBars.js    | 70 +++++++++----------
 .../src/mixins/actions/createPublicLink.js    |  3 +-
 packages/web-app-files/src/quickActions.js    | 11 ++-
 .../src/services/folder/loaderProject.ts      |  2 +-
 packages/web-app-files/src/store/actions.js   | 54 ++++++++------
 .../Links/PublicLinks/LinkEdit.spec.js        |  7 ++
 .../Links/PublicLinks/LinkInfo.spec.js        | 17 ++++-
 .../tests/unit/store/actions.spec.js          |  9 ++-
 14 files changed, 214 insertions(+), 86 deletions(-)

diff --git a/packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue b/packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue
index d868d8b7a76..eec3d9d68e2 100644
--- a/packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue
@@ -24,19 +24,39 @@
         >
           <oc-icon name="group" class="oc-mr-s" />
         </oc-button>
-        <span class="oc-mr-xs" v-text="memberShareLabel" />
+      </div>
+      <div v-if="hasLinkShares" class="oc-flex oc-flex-middle">
         <oc-button
           appearance="raw"
-          :aria-label="$gettext('Open the member panel')"
-          size="small"
-          @click="expandMemberPanel"
+          :aria-label="$gettext('Open the link panel')"
+          @click="expandLinkPanel"
         >
-          <span class="oc-text-small" v-text="$gettext('Show')"></span>
+          <oc-icon name="link" class="oc-mr-s" />
         </oc-button>
       </div>
-      <div v-if="hasLinkShares" class="oc-flex oc-flex-middle">
-        <oc-icon name="link" class="oc-mr-s" />
-        <span v-text="linkShareLabel" />
+      <div>
+        <span v-if="hasMemberShares">
+          <span v-text="memberShareLabel" />
+          <oc-button
+            appearance="raw"
+            :aria-label="$gettext('Open the member panel')"
+            size="small"
+            @click="expandMemberPanel"
+          >
+            <span class="oc-text-small" v-text="$gettext('Show.')"></span>
+          </oc-button>
+        </span>
+        <span v-if="hasLinkShares">
+          <span v-text="linkShareLabel" />
+          <oc-button
+            appearance="raw"
+            :aria-label="$gettext('Open the link panel')"
+            size="small"
+            @click="expandLinkPanel"
+          >
+            <span class="oc-text-small" v-text="$gettext('Show.')"></span>
+          </oc-button>
+        </span>
       </div>
     </div>
     <div>
@@ -203,6 +223,10 @@ export default {
 
     expandMemberPanel() {
       this.setSidebarPanel('space-share-item')
+    },
+
+    expandLinkPanel() {
+      this.setSidebarPanel('links-item')
     }
   }
 }
diff --git a/packages/web-app-files/src/components/SideBar/Links/FileLinks.vue b/packages/web-app-files/src/components/SideBar/Links/FileLinks.vue
index 23fe194bad7..728778643a0 100644
--- a/packages/web-app-files/src/components/SideBar/Links/FileLinks.vue
+++ b/packages/web-app-files/src/components/SideBar/Links/FileLinks.vue
@@ -55,7 +55,6 @@
 </template>
 <script>
 import { DateTime } from 'luxon'
-import { dirname } from 'path'
 import { mapGetters, mapActions, mapState, mapMutations } from 'vuex'
 import mixins from '../../../mixins'
 import { getParentPaths } from '../../../helpers/path'
@@ -65,6 +64,9 @@ import LinkEdit from './PublicLinks/LinkEdit.vue'
 import ListItem from './PublicLinks/ListItem.vue'
 import PrivateLinkItem from './PrivateLinkItem.vue'
 import { ShareTypes } from '../../../helpers/share'
+import { useStore } from 'web-pkg/src/composables'
+import { clientService } from 'web-pkg/src/services'
+import { dirname } from 'path'
 
 const VIEW_SHOW = 'showLinks'
 const VIEW_EDIT = 'editPublicLink'
@@ -85,6 +87,15 @@ export default {
       changeView: (view) => (this.$data.currentView = view)
     }
   },
+  setup() {
+    const store = useStore()
+    const graphClient = clientService.graphAuthenticated(
+      store.getters.configuration.server,
+      store.getters.getToken
+    )
+
+    return { graphClient }
+  },
   data() {
     return {
       VIEW_SHOW,
@@ -101,9 +112,10 @@ export default {
     ]),
     ...mapGetters(['capabilities']),
     ...mapState('Files', ['sharesTree']),
+    ...mapState(['user']),
 
     canCreatePublicLinks() {
-      return this.highlightedFile.canShare()
+      return this.highlightedFile.canShare({ user: this.user })
     },
 
     noResharePermsMessage() {
@@ -172,6 +184,9 @@ export default {
 
     privateLinkEnabled() {
       return this.capabilities.files.privateLinks
+    },
+    resourceIsSpace() {
+      return this.highlightedFile.type === 'space'
     }
   },
   watch: {
@@ -193,16 +208,25 @@ export default {
       this.currentView = VIEW_SHOW
     },
     $_reloadLinks() {
+      let storageId
+      if (this.resourceIsSpace) {
+        storageId = this.highlightedFile.id
+      } else if (this.$route.params.storageId) {
+        storageId = this.$route.params.storageId
+      }
+
       this.$_showList()
       this.loadCurrentFileOutgoingShares({
         client: this.$client,
+        graphClient: this.graphClient,
         path: this.highlightedFile.path,
         $gettext: this.$gettext,
-        storageId: this.$route.params.storageId
+        storageId,
+        resource: this.highlightedFile
       })
       this.loadSharesTree({
         client: this.$client,
-        path: dirname(this.highlightedFile.path),
+        path: this.highlightedFile.path === '' ? '/' : dirname(this.highlightedFile.path),
         $gettext: this.$gettext,
         storageId: this.$route.params.storageId
       })
diff --git a/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkActions.vue b/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkActions.vue
index ce262cc7b41..8af8c5c9e84 100644
--- a/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkActions.vue
+++ b/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkActions.vue
@@ -80,8 +80,15 @@ export default {
     },
 
     deleteLink({ client, share, resource }) {
+      let storageId
+      if (this.highlightedFile.type === 'space') {
+        storageId = this.highlightedFile.id
+      } else if (this.$route.params.storageId) {
+        storageId = this.$route.params.storageId
+      }
+
       this.hideModal()
-      this.removeLink({ client, share, resource })
+      this.removeLink({ client, share, resource, storageId })
 
       this.showMessage({
         title: this.$gettext('Public link was deleted successfully')
diff --git a/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkEdit.vue b/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkEdit.vue
index 6f3a15b3f0f..35611bff12c 100644
--- a/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkEdit.vue
+++ b/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkEdit.vue
@@ -372,11 +372,23 @@ export default {
         params.password = this.password
       }
 
+      let storageId
+      if (this.highlightedFile.type === 'space') {
+        storageId = this.highlightedFile.id
+      } else if (this.$route.params.storageId) {
+        storageId = this.$route.params.storageId
+      }
+
+      if (storageId) {
+        params.spaceRef = `${storageId}${this.highlightedFile.path}`
+      }
+
       this.addLink({
         path: this.highlightedFile.path,
         client: this.$client,
         $gettext: this.$gettext,
-        params
+        params,
+        storageId
       })
         .then((e) => {
           this.saving = false
diff --git a/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkInfo.vue b/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkInfo.vue
index c9929713b26..a1dcc43d5c6 100644
--- a/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkInfo.vue
+++ b/packages/web-app-files/src/components/SideBar/Links/PublicLinks/LinkInfo.vue
@@ -64,9 +64,9 @@
 </template>
 
 <script>
-import { basename, dirname } from 'path'
+import { basename } from 'path'
 import Mixins from '../../../../mixins'
-import { createLocationSpaces } from '../../../../router'
+import { createLocationSpaces, isLocationSpacesActive } from '../../../../router'
 import CopyToClipboardButton from '../CopyToClipboardButton.vue'
 import { DateTime } from 'luxon'
 
@@ -118,9 +118,14 @@ export default {
 
     viaRouterParams() {
       const viaPath = this.link.path
-      return createLocationSpaces('files-spaces-personal-home', {
+      const locationName = isLocationSpacesActive(this.$router, 'files-spaces-project')
+        ? 'files-spaces-project'
+        : 'files-spaces-personal-home'
+
+      return createLocationSpaces(locationName, {
         params: {
-          item: dirname(viaPath) || '/'
+          item: viaPath || '/',
+          storageId: this.$route.params.storageId
         },
         query: {
           scrollTo: basename(viaPath)
diff --git a/packages/web-app-files/src/components/SideBar/Shares/SpaceShares.vue b/packages/web-app-files/src/components/SideBar/Shares/SpaceShares.vue
index 06632eab958..6e184acd04b 100644
--- a/packages/web-app-files/src/components/SideBar/Shares/SpaceShares.vue
+++ b/packages/web-app-files/src/components/SideBar/Shares/SpaceShares.vue
@@ -9,7 +9,7 @@
           class="oc-list oc-list-divider oc-overflow-hidden oc-m-rm"
           :aria-label="$gettext('Share receivers')"
         >
-          <li v-for="collaborator in currentFileOutgoingCollaborators" :key="collaborator.key">
+          <li v-for="collaborator in members" :key="collaborator.key">
             <collaborator-list-item
               :share="collaborator"
               :modifiable="isModifiable(collaborator)"
@@ -28,7 +28,7 @@ import { useStore } from 'web-pkg/src/composables'
 import { clientService } from 'web-pkg/src/services'
 import CollaboratorListItem from './Collaborators/ListItem.vue'
 import InviteCollaboratorForm from './InviteCollaborator/InviteCollaboratorForm.vue'
-import { spaceRoleManager } from '../../../helpers/share'
+import { ShareTypes, spaceRoleManager } from '../../../helpers/share'
 import { createLocationSpaces, isLocationSpacesActive } from '../../../router'
 import { useTask } from 'vue-concurrency'
 
@@ -51,8 +51,10 @@ export default {
 
     const loadSharesTask = useTask(function* (signal, ref) {
       yield ref.loadCurrentFileOutgoingShares({
-        client: graphClient,
+        client: ref.$client,
+        graphClient,
         path: ref.space.id,
+        storageId: ref.space.id,
         resource: ref.space
       })
     })
@@ -70,17 +72,22 @@ export default {
     space() {
       return this.displayedItem.value
     },
+    members() {
+      return this.currentFileOutgoingCollaborators.filter(
+        (share) => share.shareType === ShareTypes.space.value
+      )
+    },
     sharesLoading() {
       return this.currentFileOutgoingSharesLoading
     },
     hasCollaborators() {
-      return this.currentFileOutgoingCollaborators.length > 0
+      return this.members.length > 0
     },
     currentUserCanShare() {
       return this.currentUserIsManager
     },
     currentUserIsManager() {
-      const currentUserCollaborator = this.currentFileOutgoingCollaborators.find(
+      const currentUserCollaborator = this.members.find(
         (collaborator) => collaborator.collaborator.name === this.user.id
       )
 
@@ -110,7 +117,7 @@ export default {
       }
 
       // forbid to remove last manager of a space
-      const managers = this.currentFileOutgoingCollaborators.filter(
+      const managers = this.members.filter(
         (collaborator) => collaborator.role.name === spaceRoleManager.name
       )
       return managers.length > 1
diff --git a/packages/web-app-files/src/fileSideBars.js b/packages/web-app-files/src/fileSideBars.js
index 3afc4b5ac7e..e9a2f4d7e7c 100644
--- a/packages/web-app-files/src/fileSideBars.js
+++ b/packages/web-app-files/src/fileSideBars.js
@@ -48,6 +48,15 @@ export default [
       return multipleSelection && !rootFolder
     }
   }),
+  ({ router, highlightedFile }) => ({
+    app: 'details-space-item',
+    icon: 'questionnaire-line',
+    component: SpaceDetails,
+    default: isLocationSpacesActive(router, 'files-spaces-projects'),
+    get enabled() {
+      return highlightedFile?.type === 'space'
+    }
+  }),
   ({ router, multipleSelection, rootFolder }) => ({
     app: 'actions-item',
     component: FileActions,
@@ -60,6 +69,21 @@ export default [
       return !multipleSelection && !rootFolder
     }
   }),
+  ({ highlightedFile, user }) => ({
+    app: 'space-actions-item',
+    component: SpaceActions,
+    icon: 'slideshow-3',
+    iconFillType: 'line',
+    get enabled() {
+      if (highlightedFile?.type !== 'space') {
+        return false
+      }
+      return [
+        ...highlightedFile.spaceRoles[spaceRoleManager.name],
+        ...highlightedFile.spaceRoles[spaceRoleEditor.name]
+      ].includes(user.uuid)
+    }
+  }),
   ({ capabilities, router, multipleSelection, rootFolder }) => ({
     app: 'sharing-item',
     icon: 'group',
@@ -80,12 +104,21 @@ export default [
       return false
     }
   }),
-  ({ capabilities, router, multipleSelection, rootFolder }) => ({
+  ({ highlightedFile }) => ({
+    app: 'space-share-item',
+    component: SpaceShares,
+    icon: 'group',
+    iconFillType: 'line',
+    get enabled() {
+      return highlightedFile?.type === 'space'
+    }
+  }),
+  ({ capabilities, router, multipleSelection, rootFolder, highlightedFile }) => ({
     app: 'links-item',
     icon: 'link',
     component: FileLinks,
     get enabled() {
-      if (multipleSelection || rootFolder) return false
+      if (multipleSelection || (rootFolder && highlightedFile?.type !== 'space')) return false
       if (
         isLocationTrashActive(router, 'files-trash-personal') ||
         isLocationTrashActive(router, 'files-trash-spaces-project') ||
@@ -115,38 +148,5 @@ export default [
       }
       return !!capabilities.core && highlightedFile && highlightedFile.type !== 'folder'
     }
-  }),
-  ({ router, highlightedFile }) => ({
-    app: 'details-space-item',
-    icon: 'questionnaire-line',
-    component: SpaceDetails,
-    default: isLocationSpacesActive(router, 'files-spaces-projects'),
-    get enabled() {
-      return highlightedFile?.type === 'space'
-    }
-  }),
-  ({ highlightedFile, user }) => ({
-    app: 'space-actions-item',
-    component: SpaceActions,
-    icon: 'slideshow-3',
-    iconFillType: 'line',
-    get enabled() {
-      if (highlightedFile?.type !== 'space') {
-        return false
-      }
-      return [
-        ...highlightedFile.spaceRoles[spaceRoleManager.name],
-        ...highlightedFile.spaceRoles[spaceRoleEditor.name]
-      ].includes(user.uuid)
-    }
-  }),
-  ({ highlightedFile }) => ({
-    app: 'space-share-item',
-    component: SpaceShares,
-    icon: 'group',
-    iconFillType: 'line',
-    get enabled() {
-      return highlightedFile?.type === 'space'
-    }
   })
 ]
diff --git a/packages/web-app-files/src/mixins/actions/createPublicLink.js b/packages/web-app-files/src/mixins/actions/createPublicLink.js
index 79c46ee53b4..1d83a4653af 100644
--- a/packages/web-app-files/src/mixins/actions/createPublicLink.js
+++ b/packages/web-app-files/src/mixins/actions/createPublicLink.js
@@ -36,7 +36,8 @@ export default {
         item: resources[0],
         client: this.$client,
         store: this.$store,
-        $gettext: this.$gettext
+        $gettext: this.$gettext,
+        storageId: this.$route.params.storageId
       })
     }
   }
diff --git a/packages/web-app-files/src/quickActions.js b/packages/web-app-files/src/quickActions.js
index 544583c7bdf..a25eac4b180 100644
--- a/packages/web-app-files/src/quickActions.js
+++ b/packages/web-app-files/src/quickActions.js
@@ -14,9 +14,18 @@ export function createPublicLink(ctx) {
       .toISO()
   }
 
+  if (ctx.storageId) {
+    params.spaceRef = `${ctx.storageId}${ctx.item.path}`
+  }
+
   return new Promise((resolve, reject) => {
     ctx.store
-      .dispatch('Files/addLink', { path: ctx.item.path, client: ctx.client, params })
+      .dispatch('Files/addLink', {
+        path: ctx.item.path,
+        client: ctx.client,
+        params,
+        storageId: ctx.storageId
+      })
       .then((link) => {
         ctx.store.dispatch('Files/sidebar/openWithPanel', 'links-item').then(() => {
           copyToClipboard(link.url)
diff --git a/packages/web-app-files/src/services/folder/loaderProject.ts b/packages/web-app-files/src/services/folder/loaderProject.ts
index be38f907aa9..8dd33ec2d52 100644
--- a/packages/web-app-files/src/services/folder/loaderProject.ts
+++ b/packages/web-app-files/src/services/folder/loaderProject.ts
@@ -64,7 +64,7 @@ export class FolderLoaderProject implements FolderLoader {
       ref.loadIndicators({
         client: ref.$client,
         currentFolder: currentFolder?.path,
-        storageId: ref.space.id
+        storageId: space.id
       })
 
       if (!sameRoute) {
diff --git a/packages/web-app-files/src/store/actions.js b/packages/web-app-files/src/store/actions.js
index f91a6b8e4f3..d77a30e2034 100644
--- a/packages/web-app-files/src/store/actions.js
+++ b/packages/web-app-files/src/store/actions.js
@@ -156,36 +156,51 @@ export default {
       value: computeShareTypes(state.currentFileOutgoingShares)
     })
   },
-  loadCurrentFileOutgoingShares(context, { client, path, resource, storageId }) {
+  loadCurrentFileOutgoingShares(context, { client, graphClient, path, resource, storageId }) {
     context.commit('CURRENT_FILE_OUTGOING_SHARES_SET', [])
     context.commit('CURRENT_FILE_OUTGOING_SHARES_ERROR', null)
     context.commit('CURRENT_FILE_OUTGOING_SHARES_LOADING', true)
 
+    let spaceRef
+    if (storageId) {
+      spaceRef = `${storageId}${path}`
+    }
+
     if (resource?.type === 'space') {
       const promises = []
-      const spaceShares = []
+      const spaceMembers = []
+      const spaceLinks = []
 
       for (const role of Object.keys(resource.spaceRoles)) {
         for (const userId of resource.spaceRoles[role]) {
           promises.push(
-            client.users.getUser(userId).then((resolved) => {
-              spaceShares.push(
-                buildSpaceShare(
-                  {
-                    ...resolved.data,
-                    role
-                  },
-                  resource.id
-                )
-              )
+            graphClient.users.getUser(userId).then((resolved) => {
+              spaceMembers.push(buildSpaceShare({ ...resolved.data, role }, resource.id))
             })
           )
         }
       }
 
+      promises.push(
+        client.shares.getShares(path, { reshares: true, spaceRef }).then((data) => {
+          for (const element of data) {
+            spaceLinks.push(
+              buildShare(
+                element.shareInfo,
+                context.getters.highlightedFile,
+                !context.rootGetters.isOcis
+              )
+            )
+          }
+        })
+      )
+
       return Promise.all(promises)
         .then(() => {
-          context.commit('CURRENT_FILE_OUTGOING_SHARES_SET', sortSpaceMembers(spaceShares))
+          context.commit('CURRENT_FILE_OUTGOING_SHARES_SET', [
+            ...sortSpaceMembers(spaceMembers),
+            ...spaceLinks
+          ])
           context.dispatch('updateCurrentFileShareTypes')
           context.commit('CURRENT_FILE_OUTGOING_SHARES_LOADING', false)
         })
@@ -195,11 +210,6 @@ export default {
         })
     }
 
-    let spaceRef
-    if (storageId) {
-      spaceRef = `${storageId}${path}`
-    }
-
     // see https://owncloud.dev/owncloud-sdk/Shares.html
     client.shares
       .getShares(path, { reshares: true, spaceRef })
@@ -587,7 +597,7 @@ export default {
     context.commit('SET_PUBLIC_LINK_PASSWORD', password)
   },
 
-  addLink(context, { path, client, params }) {
+  addLink(context, { path, client, params, storageId }) {
     return new Promise((resolve, reject) => {
       client.shares
         .shareFileWithLink(path, params)
@@ -595,7 +605,7 @@ export default {
           const link = buildShare(data.shareInfo, null, allowSharePermissions(context.rootGetters))
           context.commit('CURRENT_FILE_OUTGOING_SHARES_ADD', link)
           context.dispatch('updateCurrentFileShareTypes')
-          context.dispatch('loadIndicators', { client, currentFolder: path })
+          context.dispatch('loadIndicators', { client, currentFolder: path, storageId })
           resolve(link)
         })
         .catch((e) => {
@@ -617,13 +627,13 @@ export default {
         })
     })
   },
-  removeLink(context, { share, client, resource }) {
+  removeLink(context, { share, client, resource, storageId }) {
     client.shares
       .deleteShare(share.id)
       .then(() => {
         context.commit('CURRENT_FILE_OUTGOING_SHARES_REMOVE', share)
         context.dispatch('updateCurrentFileShareTypes')
-        context.dispatch('loadIndicators', { client, currentFolder: resource.path })
+        context.dispatch('loadIndicators', { client, currentFolder: resource.path, storageId })
       })
       .catch((e) => context.commit('CURRENT_FILE_OUTGOING_SHARES_ERROR', e.message))
   },
diff --git a/packages/web-app-files/tests/unit/components/SideBar/Links/PublicLinks/LinkEdit.spec.js b/packages/web-app-files/tests/unit/components/SideBar/Links/PublicLinks/LinkEdit.spec.js
index e52027884ec..2895db8b68e 100644
--- a/packages/web-app-files/tests/unit/components/SideBar/Links/PublicLinks/LinkEdit.spec.js
+++ b/packages/web-app-files/tests/unit/components/SideBar/Links/PublicLinks/LinkEdit.spec.js
@@ -552,6 +552,13 @@ function getMountedWrapper(store = createStore(), data = {}) {
     ...mountOptions(data, store),
     stubs: {
       'vue-select': VueSelect
+    },
+    mocks: {
+      $route: {
+        params: {
+          storageId: 1
+        }
+      }
     }
   })
 }
diff --git a/packages/web-app-files/tests/unit/components/SideBar/Links/PublicLinks/LinkInfo.spec.js b/packages/web-app-files/tests/unit/components/SideBar/Links/PublicLinks/LinkInfo.spec.js
index 178f021669c..66254ab9d6b 100644
--- a/packages/web-app-files/tests/unit/components/SideBar/Links/PublicLinks/LinkInfo.spec.js
+++ b/packages/web-app-files/tests/unit/components/SideBar/Links/PublicLinks/LinkInfo.spec.js
@@ -167,7 +167,7 @@ describe('LinkInfo', () => {
       expect(linkDirectTag.exists()).toBeTruthy()
       expect(linkDirectTag.props().to).toMatchObject({
         name: 'files-spaces-personal-home',
-        params: { item: '/' },
+        params: { item: '/some-path' },
         query: { scrollTo: 'some-path' }
       })
       expect(linkDirectTag.find(selectors.linkViaLabel).text()).toBe('Via some-path')
@@ -215,6 +215,21 @@ function getMountedWrapper(
     stubs,
     directives: {
       'oc-tooltip': jest.fn()
+    },
+    mocks: {
+      $router: {
+        currentRoute: { name: 'some-route' },
+        resolve: (r) => {
+          return {
+            href: r.name
+          }
+        }
+      },
+      $route: {
+        params: {
+          storageId: 1
+        }
+      }
     }
   })
 }
diff --git a/packages/web-app-files/tests/unit/store/actions.spec.js b/packages/web-app-files/tests/unit/store/actions.spec.js
index b65e4e6336c..1dcffb8e5ce 100644
--- a/packages/web-app-files/tests/unit/store/actions.spec.js
+++ b/packages/web-app-files/tests/unit/store/actions.spec.js
@@ -7,7 +7,8 @@ const stateMock = {
   dispatch: jest.fn(),
   getters: {
     highlightedFile: { isFolder: false }
-  }
+  },
+  rootGetters: {}
 }
 
 const clientMock = {
@@ -40,6 +41,11 @@ const graphClientMock = {
     getDrive: () => {
       return Promise.resolve({ data: spaceMock })
     }
+  },
+  users: {
+    getUser: () => {
+      return Promise.resolve({})
+    }
   }
 }
 const shareMock = {
@@ -81,6 +87,7 @@ describe('vuex store actions', () => {
 
       await actions.loadCurrentFileOutgoingShares(stateMock, {
         client: clientMock,
+        graphClient: graphClientMock,
         path: 'path',
         resource: dataSet.space
       })

From 1a8df6c1f1815bb509723b925675169718592696 Mon Sep 17 00:00:00 2001
From: Jannik Stehle <jannik.stehle@gmail.com>
Date: Tue, 22 Mar 2022 09:13:45 +0100
Subject: [PATCH 2/4] Fix integration tests

---
 .../tests/integration/specs/linkExpirationDate.spec.js    | 8 ++++++++
 .../web-app-files/tests/integration/specs/sidebar.spec.js | 8 ++++++++
 2 files changed, 16 insertions(+)

diff --git a/packages/web-app-files/tests/integration/specs/linkExpirationDate.spec.js b/packages/web-app-files/tests/integration/specs/linkExpirationDate.spec.js
index b780db4193f..5968c2610a6 100644
--- a/packages/web-app-files/tests/integration/specs/linkExpirationDate.spec.js
+++ b/packages/web-app-files/tests/integration/specs/linkExpirationDate.spec.js
@@ -207,6 +207,14 @@ function createStore(store) {
     Store,
     {
       modules: {
+        config: {
+          getters: {
+            configuration: () => ({
+              server: 'https://example.com',
+              options: {}
+            })
+          }
+        },
         user: {
           state: {
             id: 'alice',
diff --git a/packages/web-app-files/tests/integration/specs/sidebar.spec.js b/packages/web-app-files/tests/integration/specs/sidebar.spec.js
index 0dd788bce40..0cef899832c 100644
--- a/packages/web-app-files/tests/integration/specs/sidebar.spec.js
+++ b/packages/web-app-files/tests/integration/specs/sidebar.spec.js
@@ -47,6 +47,14 @@ const store = {
   ...Store,
   modules: {
     ...Store.modules,
+    config: {
+      getters: {
+        configuration: () => ({
+          server: 'https://example.com',
+          options: {}
+        })
+      }
+    },
     user: {
       ...Store.modules.user,
       state: {

From 54aa9cddcf53cc32a4da81c06c74c568bd0989b8 Mon Sep 17 00:00:00 2001
From: Jannik Stehle <jannik.stehle@gmail.com>
Date: Tue, 22 Mar 2022 09:42:04 +0100
Subject: [PATCH 3/4] Add changelog item, small adjustments

---
 changelog/unreleased/enhancement-spaces-link-sharing        | 6 ++++++
 .../src/components/SideBar/Details/SpaceDetails.vue         | 5 +++--
 .../src/components/SideBar/Links/FileLinks.vue              | 2 +-
 3 files changed, 10 insertions(+), 3 deletions(-)
 create mode 100644 changelog/unreleased/enhancement-spaces-link-sharing

diff --git a/changelog/unreleased/enhancement-spaces-link-sharing b/changelog/unreleased/enhancement-spaces-link-sharing
new file mode 100644
index 00000000000..f18a5909e57
--- /dev/null
+++ b/changelog/unreleased/enhancement-spaces-link-sharing
@@ -0,0 +1,6 @@
+Enhancement: Spaces link sharing
+
+Spaces and their resources can now be shared via links.
+
+https://github.com/owncloud/web/pull/6633
+https://github.com/owncloud/web/issues/6283
diff --git a/packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue b/packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue
index eec3d9d68e2..9b6353b29fe 100644
--- a/packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue
+++ b/packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue
@@ -43,9 +43,10 @@
             size="small"
             @click="expandMemberPanel"
           >
-            <span class="oc-text-small" v-text="$gettext('Show.')"></span>
+            <span class="oc-text-small" v-text="$gettext('Show')"></span>
           </oc-button>
         </span>
+        <span v-if="hasMemberShares && hasLinkShares">·</span>
         <span v-if="hasLinkShares">
           <span v-text="linkShareLabel" />
           <oc-button
@@ -54,7 +55,7 @@
             size="small"
             @click="expandLinkPanel"
           >
-            <span class="oc-text-small" v-text="$gettext('Show.')"></span>
+            <span class="oc-text-small" v-text="$gettext('Show')"></span>
           </oc-button>
         </span>
       </div>
diff --git a/packages/web-app-files/src/components/SideBar/Links/FileLinks.vue b/packages/web-app-files/src/components/SideBar/Links/FileLinks.vue
index 728778643a0..3ae6a6f7ff0 100644
--- a/packages/web-app-files/src/components/SideBar/Links/FileLinks.vue
+++ b/packages/web-app-files/src/components/SideBar/Links/FileLinks.vue
@@ -228,7 +228,7 @@ export default {
         client: this.$client,
         path: this.highlightedFile.path === '' ? '/' : dirname(this.highlightedFile.path),
         $gettext: this.$gettext,
-        storageId: this.$route.params.storageId
+        storageId
       })
     },
     linksComparator(l1, l2) {

From 7a5399fa54015c0a4d5d693deda43eea918fa58c Mon Sep 17 00:00:00 2001
From: Jannik Stehle <jannik.stehle@gmail.com>
Date: Thu, 24 Mar 2022 14:20:37 +0100
Subject: [PATCH 4/4] Bump SDK to v3.0.0-alpha.4

---
 packages/web-runtime/package.json |  2 +-
 yarn.lock                         | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/packages/web-runtime/package.json b/packages/web-runtime/package.json
index 44ea0e96e8c..73c83db4e8c 100644
--- a/packages/web-runtime/package.json
+++ b/packages/web-runtime/package.json
@@ -19,7 +19,7 @@
     "marked": "^4.0.12",
     "oidc-client": "1.11.5",
     "owncloud-design-system": "^13.0.0",
-    "owncloud-sdk": "~3.0.0-alpha.2",
+    "owncloud-sdk": "~3.0.0-alpha.4",
     "p-queue": "^6.1.1",
     "popper-max-size-modifier": "^0.2.0",
     "portal-vue": "^2.1.7",
diff --git a/yarn.lock b/yarn.lock
index 8ad83138e48..d6107e67358 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -9575,9 +9575,9 @@ __metadata:
   languageName: node
   linkType: hard
 
-"owncloud-sdk@npm:~3.0.0-alpha.2":
-  version: 3.0.0-alpha.2
-  resolution: "owncloud-sdk@npm:3.0.0-alpha.2"
+"owncloud-sdk@npm:~3.0.0-alpha.4":
+  version: 3.0.0-alpha.4
+  resolution: "owncloud-sdk@npm:3.0.0-alpha.4"
   peerDependencies:
     axios: ^0.26.0
     cross-fetch: ^3.0.6
@@ -9587,7 +9587,7 @@ __metadata:
     uuid: ^8.2.0
     webdav: 4.8.0
     xml-js: ^1.6.11
-  checksum: 46674a77d7a7c174be5876abee6f75365461f52da1ab8f2dc187602d28474a010aea06d810285a1f1b3becd7b38bd7e250019d56b607d3e3d7ac0fd6207818b3
+  checksum: de15ec2b3f5ed097eb73777192220f3e5df637d3aa2266d964c30d9fce904252ee9269f516e294fae8e8b41334508ef8e0212bda299c608d13a4e234536f9e27
   languageName: node
   linkType: hard
 
@@ -13545,7 +13545,7 @@ __metadata:
     marked: ^4.0.12
     oidc-client: 1.11.5
     owncloud-design-system: ^13.0.0
-    owncloud-sdk: ~3.0.0-alpha.2
+    owncloud-sdk: ~3.0.0-alpha.4
     p-queue: ^6.1.1
     popper-max-size-modifier: ^0.2.0
     portal-vue: ^2.1.7