Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject javascript into markDown #6526

Closed
fschade opened this issue Mar 4, 2022 · 1 comment · Fixed by #6523
Closed

Inject javascript into markDown #6526

fschade opened this issue Mar 4, 2022 · 1 comment · Fixed by #6523

Comments

@fschade
Copy link
Contributor

fschade commented Mar 4, 2022

Steps to reproduce

  1. create space
  2. edit description
  3. add [link](javascript:alert('aaa')) as content
  4. click the link in the rendered markdown

Expected behaviour

web should prevent to inject javascript or other possible dynamic contents.

Actual behaviour

javascript can be injected and executed from/for all space members

Solution

for now we sanitize the md rendered content and restrict those options, as a long term goal the backend also should handle those situations and strip out potential code parts.

@C0rby
Copy link
Contributor

C0rby commented Mar 4, 2022

as a long term goal the backend also should handle those situations and strip out potential code parts.

I don't think that this is necessary or a good idea. You might want to sync markdown files with html img tags and so on but we don't want to display that in the spaces description. I think it makes sense to just let the frontend sanitize the content before displaying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants