Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] 9.3.2.4 - Consistent labelling #5395

Closed
tbsbdr opened this issue Jun 25, 2021 · 5 comments
Closed

[a11y] 9.3.2.4 - Consistent labelling #5395

tbsbdr opened this issue Jun 25, 2021 · 5 comments
Assignees

Comments

@tbsbdr
Copy link

tbsbdr commented Jun 25, 2021


General notes

Responsive (Mobile) view: when the menue (Hamburger-Button) is closed the label of the button is "Navigationsmenü  ffnen" and when the user wants to close the menue the label of the button is "Seitenleiste schließen".
This could lead to irritations for the users. Also the area on the right of the page "Seitenleiste" appears as label in the close button "X".

Status: partly fulfilled

@pascalwengerter
Copy link
Contributor

The first part I get and it's super straightforward to fix (literally changing one string). The second part I can't grok

@kulmann
Copy link
Contributor

kulmann commented Aug 24, 2021

I looked into it and what I found is that the hamburger button in larger resolutions still shows Navigationsmenü öffnen despite the sidebar already being open. Currently fixing it. Needs a new store module though. Fixed it by renaming it to Toggle sidebar navigation menu. I'm not sure if that was the intention of the second part.

@kulmann
Copy link
Contributor

kulmann commented Aug 24, 2021

Ah, that was unrelated. Found out what was meant by looking into the german version 😅 The term Seitenleiste is already in use for the right sidebar. Apparently we're using the term for both sidebars. Needs to be more strict.

@kulmann
Copy link
Contributor

kulmann commented Aug 24, 2021

Fixed in 893bc29

@pascalwengerter
Copy link
Contributor

Just checked and can't reproduce any of the mentioned issues (app switcher and sidebar have been heavily reworked in the meantime..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants