Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] permanent link from the shares pages shows 'undefined' #12001

Closed
jnweiger opened this issue Dec 4, 2024 · 0 comments · Fixed by #12022
Closed

[QA] permanent link from the shares pages shows 'undefined' #12001

jnweiger opened this issue Dec 4, 2024 · 0 comments · Fixed by #12022
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Dec 4, 2024

Describe the bug

The web UI has multiple ways to get a permanent link for a shared file or folder.
Some of them return a useful URL, others return the string undefined

Steps to reproduce

This is reproducable with OCM shares, as well as with local shares.

To demonstrate both, we setup two machines with e.g.

env OCIS_DNSNAME=cat-7rc3-DATE OCIS_VERSION=v7.0.0-rc.3 ./deploy_ocis_bare_metal.sh
env OCIS_DNSNAME=dog-7rc3-DATE OCIS_VERSION=v7.0.0-rc.3 ./deploy_ocis_bare_metal.sh

mutually register the machines in their ocmproviders.json; service ocis restart

Alice at dog invites bob at cat. bob accepts.
Alice shares a folder with local user bob and with the remote user bob.

Both Bobs see the folder in shares -> Shared with me. The folder's 3-dots menu has a 'Copy permanent link' entry. (There is also a chain icon next to the 3-dots menu, that has the same function. When clicked, the text undefined is stored in the clipboard. BAD.

image

Alice sees the folder in shares -> Shared with others. The folder's 3-dots menu has a 'Copy permanent link' entry. (There is also a chain icon next to the 3-dots menu with the same function). When clicked, the text undefined is stored in the clipboard. BAD.

When a user actually enters the folder, another 3-dots menu appears in the folder's breadcrumbs. When clicking there, a useful URL is stored in the clipboard. OK.

image

Expected behavior

All 'Copy permanent link' elements copy a permanent link into the clipboard.

Actual behavior

some don't.

Additional context

Javascript Console shows nothing when we get this undefined.

@jnweiger jnweiger added the Type:Bug Something isn't working label Dec 4, 2024
@JammingBen JammingBen added the Priority:p2-high Escalation, on top of current planning, release blocker label Dec 4, 2024
@JammingBen JammingBen moved this from Qualification to Prio 2 in Infinite Scale Team Board Dec 4, 2024
@JammingBen JammingBen self-assigned this Dec 5, 2024
@github-project-automation github-project-automation bot moved this from Prio 2 to Done in Infinite Scale Team Board Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants