diff --git a/apps/files/src/mixins/collaborators.js b/apps/files/src/mixins/collaborators.js
index d017cff50a5..7e1c4dc0b8a 100644
--- a/apps/files/src/mixins/collaborators.js
+++ b/apps/files/src/mixins/collaborators.js
@@ -1,5 +1,6 @@
import { mapGetters } from 'vuex'
import roles from '../helpers/collaboratorRolesDefinition'
+import { shareTypes } from '../helpers/shareTypes'
export default {
computed: {
@@ -80,6 +81,21 @@ export default {
this.selectedRole = role
this.additionalPermissions = permissions
this.expirationDate = expirationDate
+ },
+
+ collaboratorType(type) {
+ switch (type) {
+ case shareTypes.user:
+ return this.$gettext('User')
+ case shareTypes.group:
+ return this.$gettext('Group')
+ case shareTypes.guest:
+ return this.$gettext('Guest')
+ case shareTypes.remote:
+ return this.$gettext('Remote user')
+ default:
+ return this.$gettext('Unknown type')
+ }
}
}
}
diff --git a/changelog/unreleased/collaborator-type b/changelog/unreleased/collaborator-type
new file mode 100644
index 00000000000..cf451b097cf
--- /dev/null
+++ b/changelog/unreleased/collaborator-type
@@ -0,0 +1,5 @@
+Enhancement: Display collaborators type
+
+We've added a new line into the collaborators autocomplete and list in the sidebar to display their type.
+
+https://github.com/owncloud/phoenix/pull/4203
diff --git a/tests/acceptance/pageObjects/FilesPageElement/SharingDialog/collaboratorsDialog.js b/tests/acceptance/pageObjects/FilesPageElement/SharingDialog/collaboratorsDialog.js
index f4df55c6ca4..8d1a21dcb04 100644
--- a/tests/acceptance/pageObjects/FilesPageElement/SharingDialog/collaboratorsDialog.js
+++ b/tests/acceptance/pageObjects/FilesPageElement/SharingDialog/collaboratorsDialog.js
@@ -236,7 +236,7 @@ module.exports = {
},
collaboratorExpirationInfo: {
selector:
- '//div/span[.="%s"]/parent::div/following-sibling::span/span[contains(text(), "Expires")]',
+ '//span[.="%s"]//ancestor::div[contains(@class, "files-collaborators-collaborator-info")]//span[contains(text(), "Expires")]',
locateStrategy: 'xpath'
}
}
diff --git a/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js b/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js
index 524bc360b99..04458be8979 100644
--- a/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js
+++ b/tests/acceptance/pageObjects/FilesPageElement/sharingDialog.js
@@ -718,7 +718,7 @@ module.exports = {
},
collaboratorAutocompleteItemName: {
selector:
- '//div[contains(@class, "files-collaborators-autocomplete-username") and text()="%s"]',
+ '//div[contains(@class, "files-collaborators-autocomplete-user-text")]/span[contains(@class, "files-collaborators-autocomplete-username") and text()="%s"]',
locateStrategy: 'xpath'
},
collaboratorsListItemInfo: {