From b1f043fbdb914f17d0c928ebc213d8bd5c58668f Mon Sep 17 00:00:00 2001 From: Jannik Stehle Date: Mon, 9 Sep 2024 15:59:00 +0200 Subject: [PATCH] feat: remove internal link type Removes the internal link type since the permanent link makes it obsolete. Existing internal links still resolve correctly to ensure backwards compatibility. --- .../enhancement-internal-link-removal | 6 +++ .../components/SideBar/Shares/FileLinks.vue | 22 +++++---- .../SideBar/Shares/Links/DetailsAndEdit.vue | 2 - .../SideBar/Shares/FileLinks.spec.ts | 16 ++---- .../src/components/CreateLinkModal.vue | 42 ++-------------- .../files/useFileActionsCopyQuicklink.ts | 21 +++++++- .../actions/files/useFileActionsCreateLink.ts | 3 +- .../src/composables/links/useLinkTypes.ts | 19 ++----- .../unit/components/CreateLinkModal.spec.ts | 30 +++--------- .../files/useFileActionsCopyQuicklink.spec.ts | 26 +++++++++- .../composables/links/useLinkTypes.spec.ts | 35 ++----------- .../features/shares/internalLink.feature | 10 ++-- .../features/spaces/internalLink.feature | 49 ------------------- 13 files changed, 90 insertions(+), 191 deletions(-) create mode 100644 changelog/unreleased/enhancement-internal-link-removal delete mode 100644 tests/e2e/cucumber/features/spaces/internalLink.feature diff --git a/changelog/unreleased/enhancement-internal-link-removal b/changelog/unreleased/enhancement-internal-link-removal new file mode 100644 index 00000000000..9d30e255e4c --- /dev/null +++ b/changelog/unreleased/enhancement-internal-link-removal @@ -0,0 +1,6 @@ +Enhancement: Internal link removal + +The internal link type has been removed because the permanent link makes it obsolete. Existing internal links still resolve correctly to ensure backwards compatibility. + +https://github.com/owncloud/web/pull/11553 +https://github.com/owncloud/web/issues/11544 diff --git a/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue b/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue index 5858f3d6992..e7dbcc6bde3 100644 --- a/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue +++ b/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue @@ -5,17 +5,14 @@

-

+
- +
{ + if (!ability.can('create-all', 'PublicLink')) { + return false + } + return canShare({ space: unref(space), resource: unref(resource) }) + }) const sharesStore = useSharesStore() const { updateLink, deleteLink } = sharesStore @@ -182,7 +186,7 @@ export default defineComponent({ const canEditLink = (linkShare: LinkShare) => { return ( - canCreateLinks({ space: unref(space), resource: unref(resource) }) && + unref(canCreateLinks) && (can('create-all', 'PublicLink') || linkShare.type === SharingLinkType.Internal) ) } diff --git a/packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue b/packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue index ff6267ad783..97458a48a5a 100644 --- a/packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue +++ b/packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue @@ -149,7 +149,6 @@ import { OcDrop } from 'design-system/src/components' import { usePasswordPolicyService } from '@ownclouders/web-pkg' import { useGettext } from 'vue3-gettext' import SetLinkPasswordModal from '../../../Modals/SetLinkPasswordModal.vue' -import { storeToRefs } from 'pinia' import { SharingLinkType } from '@ownclouders/web-client/graph/generated' import DatePickerModal from '../../../Modals/DatePickerModal.vue' import ExpirationDateIndicator from '../ExpirationDateIndicator.vue' @@ -204,7 +203,6 @@ export default defineComponent({ useLinkTypes() const resourcesStore = useResourcesStore() - const { ancestorMetaData } = storeToRefs(resourcesStore) const space = inject>('space') const resource = inject>('resource') diff --git a/packages/web-app-files/tests/unit/components/SideBar/Shares/FileLinks.spec.ts b/packages/web-app-files/tests/unit/components/SideBar/Shares/FileLinks.spec.ts index c7c04f63f93..052546a9e52 100644 --- a/packages/web-app-files/tests/unit/components/SideBar/Shares/FileLinks.spec.ts +++ b/packages/web-app-files/tests/unit/components/SideBar/Shares/FileLinks.spec.ts @@ -108,7 +108,7 @@ describe('FileLinks', () => { describe('when the add-new-link button is clicked', () => { it('should call createLink', async () => { - const { wrapper, mocks } = getWrapper({ abilities: [] }) + const { wrapper, mocks } = getWrapper() await wrapper.find(selectors.linkAddButton).trigger('click') expect(mocks.createLinkMock).toHaveBeenCalledTimes(1) }) @@ -129,7 +129,7 @@ describe('FileLinks', () => { canShare: () => true }) - it('existing viewer link is not modifiable', () => { + it('existing link is not modifiable', () => { const viewerLink = defaultLinksList[0] viewerLink.type = SharingLinkType.View const { wrapper } = getWrapper({ resource, abilities: [], links: [viewerLink] }) @@ -139,15 +139,9 @@ describe('FileLinks', () => { const isModifiable = detailsAndEdit.props('isModifiable') expect(isModifiable).toBeFalsy() }) - it('existing internal link is modifiable', () => { - const internalLink = defaultLinksList[0] - internalLink.type = SharingLinkType.Internal - const { wrapper } = getWrapper({ resource, abilities: [], links: [internalLink] }) - const detailsAndEdit = wrapper.findComponent( - linkListItemDetailsAndEdit - ) - const isModifiable = detailsAndEdit.props('isModifiable') - expect(isModifiable).toBeTruthy() + it('new links cannot be created', () => { + const { wrapper } = getWrapper({ resource, abilities: [] }) + expect(wrapper.find(selectors.linkAddButton).exists()).toBeFalsy() }) }) }) diff --git a/packages/web-pkg/src/components/CreateLinkModal.vue b/packages/web-pkg/src/components/CreateLinkModal.vue index 16be10a2d5e..f57db2fb548 100644 --- a/packages/web-pkg/src/components/CreateLinkModal.vue +++ b/packages/web-pkg/src/components/CreateLinkModal.vue @@ -24,23 +24,17 @@
-
+
@@ -52,12 +46,6 @@ class="oc-mt-s" :min-date="DateTime.now()" :label="$gettext('Expiry date')" - :disabled="selectedLinkTypeIsInternal" - :description-message=" - selectedLinkTypeIsInternal - ? $gettext('Expiry date cannot be set for internal links') - : undefined - " @date-changed="onExpiryDateChanged" />
@@ -153,10 +141,6 @@ export default defineComponent({ return $gettext('Share link(s)') } - if (unref(selectedLinkTypeIsInternal)) { - return $gettext('Copy link') - } - if (unref(passwordEnforced) || unref(password)) { return $gettext('Copy link and password') } @@ -183,12 +167,6 @@ export default defineComponent({ enforcePassword: unref(passwordEnforced) }) - const selectedLinkTypeIsInternal = computed( - () => unref(selectedType) === SharingLinkType.Internal - ) - const onlyInternalLinksAllowed = computed( - () => unref(availableLinkTypes).length === 1 && unref(selectedLinkTypeIsInternal) - ) const setAdvancedMode = () => { isAdvancedMode.value = true } @@ -218,10 +196,8 @@ export default defineComponent({ } const passwordPolicyFulfilled = computed(() => { - if (!unref(selectedLinkTypeIsInternal)) { - if (!passwordPolicy.check(unref(password).value)) { - return false - } + if (!passwordPolicy.check(unref(password).value)) { + return false } return true @@ -284,14 +260,6 @@ export default defineComponent({ const updateSelectedLinkType = (type: SharingLinkType) => { selectedType.value = type - if (unref(selectedLinkTypeIsInternal)) { - password.value = '' - password.error = '' - selectedExpiry.value = undefined - - // re-render password because it's the only way to remove policy messages - passwordInputKey.value = uuidV4() - } } onMounted(() => { @@ -317,8 +285,6 @@ export default defineComponent({ selectedType, selectedTypeIcon, selectedTypeDescription, - selectedLinkTypeIsInternal, - onlyInternalLinksAllowed, isSelectedLinkType, updateSelectedLinkType, updatePassword, diff --git a/packages/web-pkg/src/composables/actions/files/useFileActionsCopyQuicklink.ts b/packages/web-pkg/src/composables/actions/files/useFileActionsCopyQuicklink.ts index e540f720b26..6fa6f987111 100644 --- a/packages/web-pkg/src/composables/actions/files/useFileActionsCopyQuicklink.ts +++ b/packages/web-pkg/src/composables/actions/files/useFileActionsCopyQuicklink.ts @@ -1,4 +1,4 @@ -import { isLinkShare } from '@ownclouders/web-client' +import { isLinkShare, ShareTypes } from '@ownclouders/web-client' import { computed, unref } from 'vue' import { useClientService } from '../../clientService' import { useGettext } from 'vue3-gettext' @@ -8,6 +8,9 @@ import { useClipboard } from '../../clipboard' import { Resource, SpaceResource } from '@ownclouders/web-client' import { useFileActionsCreateLink } from './useFileActionsCreateLink' import { useMessages, useSharesStore } from '../../piniaStores' +import { useAbility } from '../../ability' +import { SideBarEventTopics } from '../../sideBar' +import { useEventBus } from '../../eventBus' export const useFileActionsCopyQuickLink = () => { const { showMessage, showErrorMessage } = useMessages() @@ -17,6 +20,8 @@ export const useFileActionsCopyQuickLink = () => { const { canShare } = useCanShare() const sharesStore = useSharesStore() const { copyToClipboard } = useClipboard() + const { can } = useAbility() + const eventBus = useEventBus() const { actions: createLinkActions } = useFileActionsCreateLink() const createQuicklinkAction = computed(() => @@ -56,6 +61,13 @@ export const useFileActionsCopyQuickLink = () => { return copyQuickLinkToClipboard(existingQuickLink.webUrl) } + if (!can('create-all', 'PublicLink')) { + // this is for handling an edge case where the user cannot create public links + // and no quick links exists, but a normal one does + eventBus.publish(SideBarEventTopics.openWithPanel, 'sharing') + return + } + return unref(createQuicklinkAction).handler({ space, resources }) } @@ -70,6 +82,13 @@ export const useFileActionsCopyQuickLink = () => { return false } + if ( + !can('create-all', 'PublicLink') && + !resources[0].shareTypes.includes(ShareTypes.link.value) + ) { + return false + } + return canShare({ space, resource: resources[0] }) }, class: 'oc-files-actions-copy-quicklink-trigger' diff --git a/packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts b/packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts index cea143ed14e..3daffda09df 100644 --- a/packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts +++ b/packages/web-pkg/src/composables/actions/files/useFileActionsCreateLink.ts @@ -15,7 +15,6 @@ import { } from '../../piniaStores' import { useClipboard } from '../../clipboard' import { useClientService } from '../../clientService' -import { SharingLinkType } from '@ownclouders/web-client/graph/generated' export const useFileActionsCreateLink = ({ enforceModal = false @@ -88,7 +87,7 @@ export const useFileActionsCreateLink = ({ { isQuickLink = false }: { isQuickLink?: boolean } = {} ) => { const passwordEnforced = capabilityStore.sharingPublicPasswordEnforcedFor.read_only === true - if (enforceModal || (passwordEnforced && unref(defaultLinkType) !== SharingLinkType.Internal)) { + if (enforceModal || passwordEnforced) { dispatchModal({ title: $ngettext( 'Copy link for "%{resourceName}"', diff --git a/packages/web-pkg/src/composables/links/useLinkTypes.ts b/packages/web-pkg/src/composables/links/useLinkTypes.ts index 855f666a6bf..ec706e87950 100644 --- a/packages/web-pkg/src/composables/links/useLinkTypes.ts +++ b/packages/web-pkg/src/composables/links/useLinkTypes.ts @@ -12,19 +12,7 @@ export const useLinkTypes = () => { const canCreatePublicLinks = computed(() => ability.can('create-all', 'PublicLink')) - const defaultLinkType = computed(() => { - const canCreatePublicLink = ability.can('create-all', 'PublicLink') - if (!canCreatePublicLink) { - return SharingLinkType.Internal - } - - const defaultPermissions = capabilityStore.sharingPublicDefaultPermissions - if (defaultPermissions === undefined || defaultPermissions === 1) { - return SharingLinkType.View - } - - return SharingLinkType.Internal - }) + const defaultLinkType = computed(() => SharingLinkType.View) const isPasswordEnforcedForLinkType = (type: SharingLinkType) => { if (type === SharingLinkType.View) { @@ -44,12 +32,11 @@ export const useLinkTypes = () => { const getAvailableLinkTypes = ({ isFolder }: { isFolder: boolean }): SharingLinkType[] => { if (!unref(canCreatePublicLinks)) { - return [SharingLinkType.Internal] + return [] } if (isFolder) { return [ - SharingLinkType.Internal, SharingLinkType.View, SharingLinkType.Upload, SharingLinkType.Edit, @@ -57,7 +44,7 @@ export const useLinkTypes = () => { ] } - return [SharingLinkType.Internal, SharingLinkType.View, SharingLinkType.Edit] + return [SharingLinkType.View, SharingLinkType.Edit] } // links don't have roles in graph API, hence we need to define them here diff --git a/packages/web-pkg/tests/unit/components/CreateLinkModal.spec.ts b/packages/web-pkg/tests/unit/components/CreateLinkModal.spec.ts index 84987b23d53..0dff7055ef5 100644 --- a/packages/web-pkg/tests/unit/components/CreateLinkModal.spec.ts +++ b/packages/web-pkg/tests/unit/components/CreateLinkModal.spec.ts @@ -42,17 +42,11 @@ describe('CreateLinkModal', () => { await nextTick() expect(wrapper.find(selectors.passwordInput).exists()).toBeTruthy() }) - it('should be disabled for internal links', async () => { - const { wrapper } = getWrapper({ defaultLinkType: SharingLinkType.Internal }) - wrapper.vm.isAdvancedMode = true - await nextTick() - expect(wrapper.find(selectors.passwordInput).attributes('disabled')).toBeTruthy() - }) it('should not be rendered if user cannot create public links', () => { const { wrapper } = getWrapper({ userCanCreatePublicLinks: false, - availableLinkTypes: [SharingLinkType.Internal], - defaultLinkType: SharingLinkType.Internal + availableLinkTypes: [], + defaultLinkType: SharingLinkType.View }) expect(wrapper.find(selectors.passwordInput).exists()).toBeFalsy() }) @@ -70,17 +64,11 @@ describe('CreateLinkModal', () => { await nextTick() expect(wrapper.findComponent({ name: 'oc-datepicker' }).exists()).toBeTruthy() }) - it('should be disabled for internal links', async () => { - const { wrapper } = getWrapper({ defaultLinkType: SharingLinkType.Internal }) - wrapper.vm.isAdvancedMode = true - await nextTick() - expect(wrapper.findComponent({ name: 'oc-datepicker' }).attributes('disabled')).toBeTruthy() - }) it('should not be rendered if user cannot create public links', () => { const { wrapper } = getWrapper({ userCanCreatePublicLinks: false, - availableLinkTypes: [SharingLinkType.Internal], - defaultLinkType: SharingLinkType.Internal + availableLinkTypes: [], + defaultLinkType: SharingLinkType.View }) expect(wrapper.findComponent({ name: 'oc-datepicker' }).exists()).toBeFalsy() }) @@ -93,11 +81,7 @@ describe('CreateLinkModal', () => { expect(wrapper.find(selectors.linkRoleDropDownToggle).exists()).toBeFalsy() }) it('lists all types as roles', async () => { - const availableLinkTypes = [ - SharingLinkType.View, - SharingLinkType.Internal, - SharingLinkType.Edit - ] + const availableLinkTypes = [SharingLinkType.View, SharingLinkType.Edit] const { wrapper } = getWrapper({ availableLinkTypes }) wrapper.vm.isAdvancedMode = true await nextTick() @@ -183,7 +167,7 @@ function getWrapper({ embedModeEnabled = false, callbackFn = undefined, isQuickLink = false, - availableLinkTypes = [SharingLinkType.Internal, SharingLinkType.View] + availableLinkTypes = [SharingLinkType.View] }: { resources?: Resource[] defaultLinkType?: SharingLinkType @@ -204,7 +188,7 @@ function getWrapper({ mock>({ defaultLinkType: ref(defaultLinkType), getAvailableLinkTypes: () => availableLinkTypes, - getLinkRoleByType: () => mock({ description: 'role' }), + getLinkRoleByType: () => mock({ description: 'role', label: '' }), isPasswordEnforcedForLinkType: () => passwordEnforced }) ) diff --git a/packages/web-pkg/tests/unit/composables/actions/files/useFileActionsCopyQuicklink.spec.ts b/packages/web-pkg/tests/unit/composables/actions/files/useFileActionsCopyQuicklink.spec.ts index 96844c005e0..03c74450bc7 100644 --- a/packages/web-pkg/tests/unit/composables/actions/files/useFileActionsCopyQuicklink.spec.ts +++ b/packages/web-pkg/tests/unit/composables/actions/files/useFileActionsCopyQuicklink.spec.ts @@ -7,7 +7,7 @@ import { defaultComponentMocks, getComposableWrapper } from 'web-test-helpers' import { mock } from 'vitest-mock-extended' import { FileAction } from '../../../../../src/composables/actions' import { useCanShare } from '../../../../../src/composables/shares' -import { Resource, SpaceResource } from '@ownclouders/web-client' +import { AbilityRule, Resource, SpaceResource } from '@ownclouders/web-client' import { LinkShare } from '@ownclouders/web-client' import { useClipboard } from '../../../../../src/composables/clipboard' import { useMessages } from '../../../../../src/composables/piniaStores' @@ -33,6 +33,20 @@ describe('useFileActionsCopyQuickLink', () => { } }) }) + it('should return false if user cannot create public links and no links exist', () => { + getWrapper({ + setup: ({ actions }) => { + expect( + unref(actions)[0].isVisible({ + resources: [mock({ shareTypes: [] })], + space: undefined + }) + ).toBeFalsy() + }, + canCreatePublicLinks: false + }) + }) + it('should return false if canShare is false', () => { getWrapper({ canShare: false, @@ -102,6 +116,7 @@ describe('useFileActionsCopyQuickLink', () => { function getWrapper({ setup, canShare = true, + canCreatePublicLinks = true, quickLinkExists = false }: { setup: ( @@ -109,6 +124,7 @@ function getWrapper({ mocks: Record ) => void canShare?: boolean + canCreatePublicLinks?: boolean quickLinkExists?: boolean }) { const createLinkMock = vi.fn() @@ -129,6 +145,11 @@ function getWrapper({ allowedRoles: [] }) + const abilities = [] as AbilityRule[] + if (canCreatePublicLinks) { + abilities.push({ action: 'create-all', subject: 'PublicLink' }) + } + return { wrapper: getComposableWrapper( () => { @@ -137,7 +158,8 @@ function getWrapper({ }, { mocks, - provide: mocks + provide: mocks, + pluginOptions: { abilities } } ) } diff --git a/packages/web-pkg/tests/unit/composables/links/useLinkTypes.spec.ts b/packages/web-pkg/tests/unit/composables/links/useLinkTypes.spec.ts index 76a0d864558..a993d86091f 100644 --- a/packages/web-pkg/tests/unit/composables/links/useLinkTypes.spec.ts +++ b/packages/web-pkg/tests/unit/composables/links/useLinkTypes.spec.ts @@ -11,47 +11,20 @@ describe('useLinkTypes', () => { expect(useLinkTypes).toBeDefined() }) describe('computed "defaultLinkType"', () => { - it('is internal if user can not create public links', () => { + it('is viewer', () => { getWrapper({ - abilities: [], - setup: ({ defaultLinkType }) => { - expect(unref(defaultLinkType)).toBe(SharingLinkType.Internal) - } - }) - }) - it('is viewer if user can create public links and no default permissions are given', () => { - getWrapper({ - abilities: [{ action: 'create-all', subject: 'PublicLink' }], - setup: ({ defaultLinkType }) => { - expect(unref(defaultLinkType)).toBe(SharingLinkType.View) - } - }) - }) - it('is viewer if default permissions are 1', () => { - getWrapper({ - abilities: [{ action: 'create-all', subject: 'PublicLink' }], - defaultPermissions: 1, setup: ({ defaultLinkType }) => { expect(unref(defaultLinkType)).toBe(SharingLinkType.View) } }) }) - it('is internasl if default permissions are 0', () => { - getWrapper({ - abilities: [{ action: 'create-all', subject: 'PublicLink' }], - defaultPermissions: 0, - setup: ({ defaultLinkType }) => { - expect(unref(defaultLinkType)).toBe(SharingLinkType.Internal) - } - }) - }) }) describe('method "getAvailableLinkTypes"', () => { - it('only returns the internal type if user can not create public links', () => { + it('is empty if the user cannot create public links', () => { getWrapper({ abilities: [], setup: ({ getAvailableLinkTypes }) => { - expect(getAvailableLinkTypes({ isFolder: true })).toEqual([SharingLinkType.Internal]) + expect(getAvailableLinkTypes({ isFolder: true })).toEqual([]) } }) }) @@ -60,7 +33,6 @@ describe('useLinkTypes', () => { abilities: [{ action: 'create-all', subject: 'PublicLink' }], setup: ({ getAvailableLinkTypes }) => { expect(getAvailableLinkTypes({ isFolder: true })).toEqual([ - SharingLinkType.Internal, SharingLinkType.View, SharingLinkType.Upload, SharingLinkType.Edit, @@ -74,7 +46,6 @@ describe('useLinkTypes', () => { abilities: [{ action: 'create-all', subject: 'PublicLink' }], setup: ({ getAvailableLinkTypes }) => { expect(getAvailableLinkTypes({ isFolder: false })).toEqual([ - SharingLinkType.Internal, SharingLinkType.View, SharingLinkType.Edit ]) diff --git a/tests/e2e/cucumber/features/shares/internalLink.feature b/tests/e2e/cucumber/features/shares/internalLink.feature index 6948998e711..0de1343472f 100644 --- a/tests/e2e/cucumber/features/shares/internalLink.feature +++ b/tests/e2e/cucumber/features/shares/internalLink.feature @@ -1,7 +1,7 @@ Feature: internal link share - Scenario: share a link with internal role + Scenario: opening a link with internal role Given "Admin" creates following users using API | id | | Alice | @@ -13,11 +13,9 @@ Feature: internal link share And "Alice" shares the following resource using API | resource | recipient | type | role | | myfolder | Brian | user | Can edit | - And "Alice" opens the "files" app - And "Alice" creates a public link of following resource using the sidebar panel - | resource | password | - | myfolder | %public% | - When "Alice" edits the public link named "Link" of resource "myfolder" changing role to "Invited people" + And "Alice" creates a public link of following resource using API + | resource | role | + | myfolder | Invited people | And "Brian" opens the public link "Link" And "Brian" logs in from the internal link And "Brian" navigates to the shared with me page diff --git a/tests/e2e/cucumber/features/spaces/internalLink.feature b/tests/e2e/cucumber/features/spaces/internalLink.feature deleted file mode 100644 index 8cea2b512a0..00000000000 --- a/tests/e2e/cucumber/features/spaces/internalLink.feature +++ /dev/null @@ -1,49 +0,0 @@ -Feature: internal link share in project space - - Scenario: share a link with internal role - Given "Admin" creates following users using API - | id | - | Alice | - | Brian | - | Carol | - And "Admin" assigns following roles to the users using API - | id | role | - | Alice | Space Admin | - And "Alice" logs in - And "Alice" creates the following project space using API - | name | id | - | Marketing | marketing.1 | - And "Alice" creates the following folder in space "Marketing" using API - | name | - | myfolder | - And "Alice" creates the following file in space "Marketing" using API - | name | content | - | myfolder/plan.txt | secret plan | - And "Alice" adds the following members to the space "Marketing" using API - | user | role | shareType | - | Brian | Can edit | user | - | Carol | Can view | user | - And "Alice" navigates to the project space "marketing.1" - # internal link to space - - And "Alice" creates a public link for the space with password "%public%" using the sidebar panel - And "Alice" renames the most recently created public link of space to "spaceLink" - And "Alice" edits the public link named "spaceLink" of the space changing role to "Invited people" - # internal link to folder - And "Alice" creates a public link of following resource using the sidebar panel - | resource | role | password | - | myfolder | Invited people | %public% | - And "Alice" logs out - - And "Brian" opens the public link "Link" - And "Brian" logs in from the internal link - And "Brian" uploads the following resource in internal link named "Link" - | resource | - | simple.pdf | - And "Brian" logs out - - When "Carol" opens the public link "spaceLink" - And "Carol" logs in from the internal link - And "Carol" opens folder "myfolder" - Then "Carol" should not be able to edit file "simple.pdf" - And "Carol" logs out