Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review local API tests that were skipped on OCIS storage #225

Open
phil-davis opened this issue Sep 14, 2020 · 1 comment
Open

Review local API tests that were skipped on OCIS storage #225

phil-davis opened this issue Sep 14, 2020 · 1 comment

Comments

@phil-davis
Copy link

In owncloud/ocis and owncloud/ocis-reva there are local API test scenarios. Those scenarios demonstrate existing bugs. When the bug is fixed, the bug-demo scenario should be deleted and there should be some scenario(s) in the core API tests that demonstrate the correct behavior and start passing.

In owncloud/ocis@b953b5e various local API test scenarios were skipped on the new "ocis" storage. They were skipped because they "fail" - i.e. the behavior has changed. Either:

  • the behavior is different but not yet correct on "ocis" storage. In that case, add a scenario to demonstrate how it behaves on "ocis" storage
  • the behavior is correct (the bug if fixed on "ocis" storage. In that case, add some extra comment to scenario so future readers know that the bug really is just evident on "owncloud" storage, and that "ocis" storage is fine.
@phil-davis phil-davis self-assigned this Sep 14, 2020
@phil-davis phil-davis changed the title Review lcoal API tests that were skipped on OCIS storage Review local API tests that were skipped on OCIS storage Sep 14, 2020
@phil-davis phil-davis removed their assignment Jan 18, 2021
@phil-davis
Copy link
Author

I removed my assignment because I have not got to doing this! Someone else should be able to look through the scenarios and sort out what to do.

ocis-reva is gone since I made this issue. So ignore that.

Look through the "local" API tests in https://github.com/owncloud/ocis/tree/master/tests/acceptance/features

If the scenario now demonstrates the correct behaviour, then:

If the scenario is still demonstrating "bad behaviour", then find and check the "good behaviour" scenario in owncloud/core. Also check the referenced issue. Update any references that are out-of-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants