Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Fix the tests #858

Closed
dpakach opened this issue May 31, 2021 · 3 comments
Closed

Fix the tests #858

dpakach opened this issue May 31, 2021 · 3 comments
Labels

Comments

@dpakach
Copy link
Contributor

dpakach commented May 31, 2021

these issues in pact-js are fixed now
pact-foundation/pact-js#632
pact-foundation/pact-js#633

we still have a lot of tests skipped because of these issues,
we need to go through the tests and unskip them now

@dpakach
Copy link
Contributor Author

dpakach commented May 31, 2021

This will require the updated version of pact-js
https://github.com/pact-foundation/pact-js/releases/tag/v10.0.0-beta.36

@dpakach dpakach self-assigned this May 31, 2021
@dpakach
Copy link
Contributor Author

dpakach commented Jun 4, 2021

#859 updates pactjs to the latest version
while pact-foundation/pact-js#633 is fixed, pact-foundation/pact-js#632 is not fixed yet, so moving it to backlog till then

@dpakach dpakach removed their assignment Jun 7, 2021
@pascalwengerter
Copy link
Contributor

Closed in favor of #924 which includes (I suppose) bumping pact-js and sorting out skipped tests that were enabled from the newer version

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants