Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sharing-Ng]Add API test coverage for PROPFIND shared resources with same name #8493

Closed
2 tasks done
PrajwolAmatya opened this issue Feb 20, 2024 · 3 comments
Closed
2 tasks done
Assignees
Labels

Comments

@PrajwolAmatya
Copy link
Contributor

PrajwolAmatya commented Feb 20, 2024

Description

Currently, we do not have test coverage for PROPFIND the shared resources with same name. When two users share resource with same name, it is expected to have suffix(1) added on the second share.

Current behavior for PROPFIND request of the shared resources for old and new dav path returns suffix(1) in the response as <oc:name>test-folder (1)</oc:name>. In case of spaces dav path the response returns <oc:name>test-folder</oc:name>.

Cover tests for old , new and spaces dav paths

- [ ] shareid (#8510)

Related issues:

@grgprarup
Copy link
Contributor

Tests coverage for Add test coverage for PROPFIND of shared resources with same name are added and all related PRs are merged.

@PrajwolAmatya
Copy link
Contributor Author

Which ids are we actually checking here? Checking fileid has been already covered in #8674 and we do not get shareid in the PROPFIND response.
cc @amrita-shrestha @nabim777 @saw-jan

@nirajacharya2
Copy link
Contributor

From the list of issues mentioned above in the description, only one issue #8510 is remained as bug. So, it will be tracked in #8428
So closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants