Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: WOPI validator #5111

Open
2 of 3 tasks
wkloucek opened this issue Nov 24, 2022 · 8 comments
Open
2 of 3 tasks

Tests: WOPI validator #5111

wkloucek opened this issue Nov 24, 2022 · 8 comments
Labels
Category:Enhancement Add new functionality QA

Comments

@wkloucek
Copy link
Contributor

wkloucek commented Nov 24, 2022

#5089 introduced the WOPI validator in CI for:

  • personal spaces

We need to run the WOPI validator also for:

  • public links
  • shares
  • ...

Places where we should run the WOPI validator:

  • oCIS
  • REVA
  • WOPI server collaboration service
@stale
Copy link

stale bot commented Jan 26, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Jan 26, 2023
@micbar micbar added the Category:Enhancement Add new functionality label Jan 26, 2023
@dragotin
Copy link
Contributor

I think the validator should run in the WOPI Server repo. @tbsbdr @micbar can we please put that in the backlog? It is an important part of the product.

@micbar
Copy link
Contributor

micbar commented Jun 30, 2023

We have already a ticket in the repo cs3org/wopiserver#57

@micbar
Copy link
Contributor

micbar commented Jun 30, 2023

I proposed this already, was somehow dropped from their roadmap.

@dragotin
Copy link
Contributor

dragotin commented Jul 2, 2023

Yes, we can not expect that CERN is hardening our oCIS product for which we need the WOPI. I think the task should be in our backlog.

@wkloucek
Copy link
Contributor Author

wkloucek commented Nov 5, 2024

Places where we should run the WOPI validator:
...

  • WOPI server

Could be considered as a checkmarked now, since oCIS 6 / 7 has the collaboration service instead of the WOPI server.

@wkloucek
Copy link
Contributor Author

wkloucek commented Nov 5, 2024

@micbar today found something interesting in #10462 (comment):

While digging into the upstream repo, i found this microsoft/wopi-validator-core#22 (comment) which means the upstream status of the WOPI Validator is unclear.

@micbar
Copy link
Contributor

micbar commented Nov 5, 2024

@wkloucek @individual-it

That is correct. Until now this is just an announcement. Things didn’t change so far.

Please Note: if you use ms365 in a production env, every user can just create a *.wopitest file and open in in ms365 cloud. This will run the same validator in the WebUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality QA
Projects
None yet
Development

No branches or pull requests

3 participants