Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the creation of the demo users by default #3181

Closed
cdamken opened this issue Feb 16, 2022 · 2 comments · Fixed by #3474
Closed

Disable the creation of the demo users by default #3181

cdamken opened this issue Feb 16, 2022 · 2 comments · Fixed by #3474
Labels
Category:Change Change existing functionality Priority:p3-medium Normal priority Topic:Security Type:Story User Story

Comments

@cdamken
Copy link

cdamken commented Feb 16, 2022

By default, the demo users are enabled,

I would propose by default to have:

      ACCOUNTS_DEMO_USERS_AND_GROUPS: false

and only if the developers want to have a testing environment could be enabled.

Otherwise, this could produce a security issue if someone forgets it.

Acceptance criteria
[ ] demo users are not created when starting oCIS out of the box (docker, binary)
[ ] getting started doc needs adjustments
[ ] test deployments need to enable demo users explicitly
[ ] tests in web repository need to be adapted (eg. check if they still work)
[ ] deployments in web repository need to be checked
[ ] enable demo user in VS code launch config
[ ] setting service doesn't assign roles to demo users if flag is set to false

@micbar micbar added Category:Change Change existing functionality Topic:Security and removed Type:Bug labels Feb 16, 2022
@micbar
Copy link
Contributor

micbar commented Feb 16, 2022

Thanks carlos for pointing it out.

IMO we should solve this during build time. The locally self compiled binary should still have the demo users, and the docker image and the official binary should set the value to false

@micbar micbar added the Priority:p3-medium Normal priority label Feb 16, 2022
@wkloucek
Copy link
Contributor

To have a secure oCIS instance, there is more than deleting the demo users. I agree on having them disabled by default for released binaries as soon as were in Beta.

But we should also find a solution for the default secrets (https://owncloud.dev/ocis/deployment/#secure-an-ocis-instance), at least for the single process use case.

@settings settings bot removed the p3-medium label Mar 11, 2022
@micbar micbar changed the title Disable the demo users by default Disable the creation of the demo users by default Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Change Change existing functionality Priority:p3-medium Normal priority Topic:Security Type:Story User Story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants