Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable archive download by resourceid #2521

Closed
butonic opened this issue Sep 17, 2021 · 4 comments
Closed

enable archive download by resourceid #2521

butonic opened this issue Sep 17, 2021 · 4 comments

Comments

@butonic
Copy link
Member

butonic commented Sep 17, 2021

As a follow-up of cs3org/reva#2066
The current implementation only handles path based requests.

For the spaces concept we need to be able to download archives that contain a list of resource ids.

@jvillafanez
Copy link
Member

I guess the question here is, who's going to convert the resource id to a path?

So far, ocis is mostly routing the request to the archiver service. As such, converting the resource id to a path doesn't seem possible in ocis unless we change the approach.

The alternative is that the archiver handles the resource id by itself, converting it to a path if needed. In this case, ocis shouldn't need any change, but reva.

@butonic
Copy link
Member Author

butonic commented Sep 17, 2021

The case I have in mind is when the resourceid comes from a PROPFIND /dav/spaces/<spaceid></optional/relative/path>. The references we give to the archiver are opaque to it. It only needs to fetch the resources using references that contain the spaceid and the path. They were introduced with cs3org/reva#1721 and are used whenever accessing a storage space. They can also transport plain paths, so it should be possible to extend the axisting /archive implementation with relative references.

@wkloucek
Copy link
Contributor

Will be fixed by cs3org/reva#2100

@kulmann
Copy link
Contributor

kulmann commented Oct 7, 2021

Linked PR is merged, archive download by base64 encoded resourceid now works. Closing here.

@kulmann kulmann closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants