Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Add capability for app provider? #2482

Closed
pascalwengerter opened this issue Sep 9, 2021 · 4 comments · Fixed by #2529
Closed

[Question] Add capability for app provider? #2482

pascalwengerter opened this issue Sep 9, 2021 · 4 comments · Fixed by #2529

Comments

@pascalwengerter
Copy link
Contributor

Describe the solution you'd like

I suggest adding a capability for app provider since oCIS supports that feature and OC10 (most likely) never will.

Describe alternatives you've considered

The wrapper for external apps will most likely be enabled via the config.json in web, but the request to fetch the list of provided apps should perhaps only happen if capabilities allow for it.

@pascalwengerter
Copy link
Contributor Author

@wkloucek @micbar @kulmann opinions? Should be done rather quickly :)

@kulmann
Copy link
Contributor

kulmann commented Sep 10, 2021

Like you said, adding the app provider application to the web config.json is probably the easiest on/off switch for the app. Since the app provider backend service is not part of oCIS by default (at least as far as I know now) it would be nice to have a reliable way to know if the backend service is available or not. For easy deployments I'd still be in favor of including the app provider frontend extension in the default config of oCIS. One dead simple way would be to just make a request to the endpoint you mentioned - if it fails we know that the service is not reachable (for whatever reasons, not started, downtime, etc). I'd prefer a more gentle way to announce it. The capabilities are the closest we have as of now and it saves us an additional request, so I'm in favor of adding such a capability.

There was another idea some time ago, which was basically to have an endpoint for listing available ocis extensions/services. From what I know we could add such a list to the capabilities endpoint as well (like capabilities.services). However, that was not discussed further and doesn't exist as of now, so not relevant for the issue at hand.

@micbar
Copy link
Contributor

micbar commented Sep 10, 2021

Adding a capability in ocis is quite simple.

@wkloucek
Copy link
Contributor

Will be tackled in cs3org/reva#2088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants