Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails API compatibility with oc10 #1913

Closed
exalate-issue-sync bot opened this issue Apr 13, 2021 · 3 comments
Closed

Thumbnails API compatibility with oc10 #1913

exalate-issue-sync bot opened this issue Apr 13, 2021 · 3 comments
Labels
Type:Story User Story

Comments

@exalate-issue-sync
Copy link

As oCIS developers we want the thumbnails API to be compatible with the OC10 API so that setups with oc10 backend and oCIS web frontend can easily transition to oCIS backend.

Acceptance criteria

  • The APIs bahave the same (can be verified using the acceptance tests)
@exalate-issue-sync
Copy link
Author

David Christofas commented: I looked through the expected failures and many of them will be solve with this PR: #1898

@exalate-issue-sync
Copy link
Author

David Christofas commented: Most of the failures in the test suite are from thumbnails for .txt files which we don't yet support in ocis.

@exalate-issue-sync
Copy link
Author

David Christofas commented: Thumbnail support for .txt files was implemented here.
#1988

Now most of the remaining failing tests are about not matching resolutions. This is because we don't allow freely chosen resolutions but instead map the requested resolution to the closest matching pre configured one. That way it's not possible to spam the storage with thumbnail files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
None yet
Development

No branches or pull requests

0 participants