Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't depend on the etag query parameter #1473

Closed
C0rby opened this issue Jun 18, 2020 · 1 comment · Fixed by #1898
Closed

Don't depend on the etag query parameter #1473

C0rby opened this issue Jun 18, 2020 · 1 comment · Fixed by #1898
Assignees
@C0rby

Comments

@C0rby
Copy link
Contributor

C0rby commented Jun 18, 2020

Currently clients have to send the etag in the request but in OC10 it was not strictly required.
Change the implementation of the service to not depend on the etag.
https://demo.owncloud.com/remote.php/dav/files/demo/meme1.jpg?c=d04ca18aff0316743074b68a9a13149c&x=32&y=32&forceIcon=0&preview=1
c=d04ca18aff0316743074b68a9a13149c is the etag part.
@C0rby C0rby self-assigned this Jun 18, 2020
@haribhandari07 haribhandari07 transferred this issue from owncloud/ocis-thumbnails Jan 25, 2021
@haribhandari07 haribhandari07 mentioned this issue Feb 1, 2021
Closed
7 tasks
@phil-davis
Copy link
Contributor

@C0rby this is an old issue that was transferred from the archived ocis-thumbnails repo a few weeks ago.
Please close if no longer relevant.

@C0rby C0rby mentioned this issue Feb 22, 2021
Closed
@settings settings bot removed the p3-medium label Apr 7, 2021
@C0rby C0rby mentioned this issue Apr 9, 2021
Merged
@C0rby C0rby linked a pull request Apr 9, 2021 that will close this issue
Thumbnails for public links #1898
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Thumbnails for public links owncloud/ocis
2 participants
@phil-davis @C0rby