Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable static web assets caching #1094

Closed
exalate-issue-sync bot opened this issue Dec 14, 2020 · 3 comments · Fixed by #3109
Closed

Re-enable static web assets caching #1094

exalate-issue-sync bot opened this issue Dec 14, 2020 · 3 comments · Fixed by #3109

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Dec 14, 2020

There has been caching in place for static web assets for a few weeks. It was not stable. Needs investigation so that it can be re-enabled reliably.

The idea was to set the last modification date of assets to the most recent service start time, since we can't determine the time of asset generation (yet?), but enforce so called revalidation on each request. This means that even within the supposed cache lifetime of the resource, the browser checks with the remote service if the resource remains unchanged. In that case it is allowed to be used from cache, even if it's expired.

Needs to be reenabled in

  • ocis-pkg/middleware/static.go and
  • web/pkg/service/v0/service.go

We should check first, if the revalidation really takes place / is successful.

@stale
Copy link

stale bot commented Feb 12, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Feb 12, 2021
@stale stale bot closed this as completed Feb 22, 2021
@diocas
Copy link

diocas commented Oct 27, 2021

Hi, maybe this ticket should be re-opened?

@pascalwengerter
Copy link
Contributor

@diocas you're right. Also, if you add the bug or technical-debt label it doesn't get picked up by stalebot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants