Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

ocs v2 endpoint still returns ocs v1 status codes #26

Closed
individual-it opened this issue Jan 27, 2020 · 4 comments · Fixed by cs3org/reva#696
Closed

ocs v2 endpoint still returns ocs v1 status codes #26

individual-it opened this issue Jan 27, 2020 · 4 comments · Fixed by cs3org/reva#696
Assignees
Labels
bug Something isn't working

Comments

@individual-it
Copy link
Member

compare results of ocs/v1.php and ocs/v2.php endpoint
e.g. curl http://localhost:9140/ocs/v1.php/config -u user0:123456 | xmllint --format -

both endpoints return

 <meta>
    <status>ok</status>
    <statuscode>100</statuscode>
    <message>OK</message>
  </meta>

but the v2 endpoint should return status-code 200 that is the same as the HTTP status code

@individual-it individual-it added the bug Something isn't working label Jan 27, 2020
@individual-it
Copy link
Member Author

when trying to access the users endpoint with an authenticated user but one that is different to the one that is requested e.g. http://localhost:9140/ocs/v1.php/cloud/users/user1 -u user0:123456 its opposite, the OCS status code is 403 in both cases but the HTTP status code is 200

@individual-it
Copy link
Member Author

not existing endpoints but with an authorised user return HTTP 200 and OCS 998 on both v1.php and v2.php

@PVince81
Copy link
Contributor

PVince81 commented May 7, 2020

@C0rby I see you fixed part of it in cs3org/reva#696

what's left to do ? a checkbox list might be useful

@C0rby
Copy link
Contributor

C0rby commented May 8, 2020

Those are the last tests that still need some work.

tests/acceptance/features/apiAuth/cors.feature:1
tests/acceptance/features/apiShareManagementBasic/createShare.feature:37
tests/acceptance/features/apiShareManagementBasic/createShare.feature:76
tests/acceptance/features/apiShareManagementBasic/createShare.feature:194
tests/acceptance/features/apiShareManagementBasic/createShare.feature:224

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants