Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

use session storage instead of local storage #1612

Merged
merged 1 commit into from
Aug 24, 2016
Merged

Conversation

ChristophWurst
Copy link
Contributor

Motivation for switching to this shorter-lived storage:

  • we store sensitive information in the browser storage, which lives forever if you local storage
  • if the cache is old (1d old or older) chances are high it's worthless as the messages in your folders changed already and the cached ones will be deleted anyway
  • cache only speeds up page refreshes, so it doesn't really help if our AJAX calls are slow
  • if we built better data structures on the client side, we don't have to cache stuff. we can simply built up a data structure of accounts, folders and messages and use the data that has already been loaded before

@LukasReschke @jancborchardt @owncloud/mail please review and tell me what you think. Closing a tab or closing the browser will clear the storage, but I could not really notice the interface loading slower.

@ChristophWurst
Copy link
Contributor Author

@jancborchardt ping

@jancborchardt
Copy link
Contributor

Works, doesn’t break anything :) 👍

@jancborchardt jancborchardt merged commit baa2ba4 into master Aug 24, 2016
@jancborchardt jancborchardt deleted the session-storage branch August 24, 2016 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants