This repository has been archived by the owner on Nov 8, 2018. It is now read-only.
scroll to refresh even when already at top of list, fix #1588 #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jancborchardt, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst and @Gomez to be potential reviewers |
|
Yo @owncloud/mail folks, review this awesome JS hacking I brought into the world. ;D |
|
I don't get it. How to refresh? Before and after this PR? |
It's like pull to refresh on mobile. |
|
👎 this triggers 💯s of requests to check messages. We need to debounce the event somehow, let me fix this |
|
should be good now, please test it @jancborchardt The only issue left is that it sometimes also reloads if one scrolls down. I assume the scroll event also fires with top === 0. Maybe we have to store the last scroll position to distinguish the direction. Could be fixed in another PR. |
|
Nice! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review my beginner Backbone code :D @ChristophWurst @Gomez
At least from testing it seems to work fine, no glitches seen yet.