-
Notifications
You must be signed in to change notification settings - Fork 76
Conversation
By analyzing the blame information on this pull request, we identified @DeepDiver1975, @LukasReschke and @jancborchardt to be potential reviewers |
@otbe @tahaalibra @Scheirle easy to review :-) |
@otbe @tahaalibra since you reported / were involved in the original issue, can you please review this? |
@@ -25,6 +25,8 @@ | |||
|
|||
namespace OCA\Mail\Controller; | |||
|
|||
use Exception; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are using this...we can change \Exception $ex to Exception $ex on line 236
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. Thanks
7d0b3d9
to
8e5a06a
Compare
8e5a06a
to
ce190d5
Compare
Are you sure
Looks like you pushed it into production without enough testing… ;) And now I can't access my server because the update failed and still keeps failing |
Hi @viki53, Btw. this has been fixed already. Keep in mind this app is still under development ;-) |
Okay, so when will this fix be pushed to the OC servers? Because in the meantime, my server is kinda dead, as the update fails to pass and the server stays in maintenance mode. :-/ I'd be glad to test some apps, but I don't really use this one enough to test it (I just have it in case I'd need a webmail for some of my addresses some day). |
This is an open source project, it's done when it's done ;-) It depends on which owncloud core version you're using. On newer ones, manually patching will make the code integrity check fail. So that might not be an option. |
I did try fixing that manually, but I still have the old file (with The update triggers the error I mentioned earlier, so I guess it's not applied and the new files not saved. |
fixes #1421