Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock original file when doing operations on versions #17269

Closed
PVince81 opened this issue Jul 1, 2015 · 5 comments
Closed

Lock original file when doing operations on versions #17269

PVince81 opened this issue Jul 1, 2015 · 5 comments

Comments

@PVince81
Copy link
Contributor

PVince81 commented Jul 1, 2015

Steps

  1. Put sleep(30) here https://github.com/owncloud/core/blob/v8.1.3/apps/files_versions/lib/storage.php#L310 in the rollback/restore function of the versions app
  2. Create a text file "test.txt"
  3. Edit it several times to create versions
  4. Open the versions dropdown
  5. Restore an older version
  6. In a separate tab (or WebDAV) try renaming "test.txt" to "re.txt"

Expected result

File cannot be renamed while the restore operation is in progress

Actual result

File can be renamed

Versions operations like download and restore should set locks on the original file.
Similar to #17245 but different reproduction steps.
The fix might be the same for both.

@PVince81 PVince81 added this to the 8.1.1-next-maintenance milestone Jul 1, 2015
@DeepDiver1975 DeepDiver1975 modified the milestones: 8.1.2-next-maintenance, 8.1.1-current-maintenance Jul 20, 2015
@ghost ghost modified the milestones: 8.1.3-next-maintenance, 8.1.2-current-maintenance Aug 25, 2015
@MorrisJobke MorrisJobke modified the milestones: 8.1.3, 8.1.4-current-maintenance Sep 13, 2015
@PVince81
Copy link
Contributor Author

I'll verify whether #19538 (8.2) fixes this.

Also not sure why this is on 8.1.4 and 8.2.

@PVince81
Copy link
Contributor Author

This won't work, that rollback function must lock the file before operating.

@ghost ghost modified the milestones: 9.0-next, 8.1.4-current-maintenance Oct 14, 2015
@PVince81
Copy link
Contributor Author

PVince81 commented Feb 8, 2016

I thought we fixed that, maybe not. Need to verify.

@PVince81 PVince81 modified the milestones: 9.0.1-next-maintenance, 9.0-current Feb 23, 2016
@ghost ghost modified the milestones: 9.0.2-next-maintenance, 9.0.1-current-maintenance Mar 9, 2016
@ghost ghost modified the milestones: 9.0.3-next-maintenance, 9.0.2-current-maintenance Apr 14, 2016
@PVince81 PVince81 modified the milestones: 9.0.4-next-maintenance, 9.0.3-current-maintenance Jun 2, 2016
@PVince81 PVince81 modified the milestones: 9.0.5, 9.0.4 Jul 18, 2016
@PVince81 PVince81 added this to the 9.0.6 milestone Sep 21, 2016
@PVince81 PVince81 removed this from the 9.0.5 milestone Sep 21, 2016
@PVince81 PVince81 modified the milestones: 9.0.7, 9.0.6 Oct 20, 2016
@PVince81 PVince81 modified the milestones: 9.2, 9.0.7 Nov 30, 2016
@PVince81 PVince81 modified the milestones: backlog, 10.0 Apr 7, 2017
@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants