-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock original file when doing operations on versions #17269
Comments
I'll verify whether #19538 (8.2) fixes this. Also not sure why this is on 8.1.4 and 8.2. |
This won't work, that rollback function must lock the file before operating. |
I thought we fixed that, maybe not. Need to verify. |
Hey, this issue has been closed because the label (This is an automated comment from GitMate.io.) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Steps
sleep(30)
here https://github.com/owncloud/core/blob/v8.1.3/apps/files_versions/lib/storage.php#L310 in the rollback/restore function of the versions appExpected result
File cannot be renamed while the restore operation is in progress
Actual result
File can be renamed
Versions operations like download and restore should set locks on the original file.
Similar to #17245 but different reproduction steps.
The fix might be the same for both.
The text was updated successfully, but these errors were encountered: