Download user's directory&files as zip while missing fileid is called by URLlink.

[ynott]

Steps to reproduce

1. external storage(S3,CIFS Server,etc) mount to ownCloud.
2. make a url link for sharing.
3. shutdown the external storage server.
4. run the file:scan.
5. boot the external stoarge server.
6. run the file:scan again ( lost fileid from Database! this fileid is associated shared URL link.)
7. access the url link and click download button.
8. user's all files,directory are download(include external storage mounted).

Expected behaviour

Return file not found.

Actual behaviour

get user's all folder and files as Zip.

Server configuration

Operating system: CentOS 6.5

Web server: Apache 2.2

Database: MySQL 5.6.23

PHP version: 5.4.37

ownCloud version: 8.0

[ynott]

Similar problem.
Download directory as zip while an inner file is being overwritten causes the download to be corrupted
#16960

[ynott]

Sorry, missing close.
reopened.

[ynott]

https://github.com/owncloud/core/blob/master/apps/files_sharing/lib/controllers/sharecontroller.php#L258

If self::getPath($token) has returned a string ""
$originalSharePath = "";
and then go through to
https://github.com/owncloud/core/blob/master/apps/files_sharing/lib/controllers/sharecontroller.php#L298
All user's files and directory download.

[LukasReschke]

Are you on 8.0.3? - If not: Update.

[PVince81]

I guess this ticket is more about error handling for zip files.
When building zip files, if something goes wrong in the middle then one would get a corrupt file, or incomplete zip files.

This might not be solvable as files are streamed into the zip file on the fly, unless we can have some kind of integrity check before that. (ex: can file be decrypted in case of encryption ? is file properly readable ?)

[ynott]

@LukasReschke
I updated to 8.0.4 , this problem did not occur. thanks a lot!
@PVince81
Yes,zip file error occur, but I focus not to be download.

Thanks for solving my issue.