Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly show locked file error message in web UI #16701

Closed
7 of 8 tasks
PVince81 opened this issue Jun 3, 2015 · 6 comments
Closed
7 of 8 tasks

Properly show locked file error message in web UI #16701

PVince81 opened this issue Jun 3, 2015 · 6 comments

Comments

@PVince81
Copy link
Contributor

PVince81 commented Jun 3, 2015

Whenever a file is locked, instead of hanging, the web UI needs to show a proper error message.

Currently the network console will return "500 Internal server error" and the log will show that there was a LockingException.

The LockingException needs to be caught properly in the ajax endpoints to be translated into a proper error message.

Needed to be able to show the locking exceptions:

  • rename
  • move
  • new file
  • new folder
  • delete
  • upload
  • download
  • getstoragestats
@PVince81 PVince81 added this to the 8.1-current milestone Jun 3, 2015
@PVince81 PVince81 self-assigned this Jun 3, 2015
@PVince81
Copy link
Contributor Author

PVince81 commented Jun 3, 2015

This will require fixing all the ajax calls of the files web UI to properly catch exceptions and actually return them: (something which seems to have been missing for a long while)

@PVince81
Copy link
Contributor Author

PVince81 commented Jun 3, 2015

PR here #16718

@PVince81
Copy link
Contributor Author

PVince81 commented Jun 5, 2015

The PR above fixed many operations but not "Download".
Keeping open to address the "download" case which is more tricky.

@PVince81
Copy link
Contributor Author

Download case here #17009

@DeepDiver1975
Copy link
Member

getstoragestats

do we really need this? what's the impact? THX

@PVince81
Copy link
Contributor Author

Probably not needed.
If that call fails because scanning failed, then the "max upload size" or "free space" will not be updated on the upload button, which isn't that bad.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants